Remove old code#49
Merged
Merged
Conversation
|
Coverage for this change: 62.4% |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo pkg/types string utility package (and its tests/docs) and updates callers to use the equivalent types utilities from github.com/mutablelogic/go-server/pkg/types instead.
Changes:
- Deleted the legacy
pkg/typespackage files (string helpers + package docs) and associated unit tests. - Updated imports in core query/binding and listener code to use
github.com/mutablelogic/go-server/pkg/types.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/string.go | Removed legacy string quoting/classification helpers from this module. |
| pkg/types/string_test.go | Removed tests for the deleted legacy pkg/types helpers. |
| pkg/types/doc.go | Removed package documentation for the deleted pkg/types package. |
| listener.go | Switched types import to go-server/pkg/types for identifier quoting in LISTEN/UNLISTEN. |
| bind.go | Switched types import to go-server/pkg/types for quoting and substitution helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
15
| // Packages | ||
| pgx "github.com/jackc/pgx/v5" | ||
| types "github.com/mutablelogic/go-pg/pkg/types" | ||
| types "github.com/mutablelogic/go-server/pkg/types" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.