Update Docker build process for new version#52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Docker image build/publish pipeline to align with newer GitHub Actions runners/actions and to standardize Docker tagging + manifest creation across architectures.
Changes:
- Switch release trigger from
createdtopublishedand centralize Docker-related env vars in the workflow. - Update build runners to Ubuntu 24.04 (including ARM runner) and bump
actions/checkout+docker/login-actionmajor versions. - Normalize Docker image tags to
${DOCKER_REPO}:${VERSION}-${OS}-${ARCH}and update manifest creation to match.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Makefile |
Updates Docker tag format used by make docker / make docker-push to match multi-arch manifest expectations. |
.github/workflows/docker.yaml |
Updates release trigger, runner images, action versions, and manifest/tag logic for consistent multi-arch publishing. |
Comments suppressed due to low confidence (1)
.github/workflows/docker.yaml:11
DOCKER_SOURCEis now set togithub.com/${{ github.repository }}(no scheme). The Dockerfile uses this value fororg.opencontainers.image.source, which is expected to be a URL; droppinghttps://makes the label less useful and differs from the Dockerfile default.
env:
DOCKER_REPO: ghcr.io/${{ github.repository_owner }}/pgmanager
DOCKER_SOURCE: github.com/${{ github.repository }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage for this change: 62.4% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker build workflow to improve consistency, reliability, and compatibility with newer GitHub Actions and Docker best practices. The main changes include updating action versions, improving environment variable usage, and adjusting Docker tagging and manifest creation logic.
Workflow and Docker build improvements:
publishedreleases instead ofcreatedfor more accurate Docker image publishing.amd64andarm64architectures for better compatibility and consistency.actions/checkoutto v6 anddocker/login-actionto v4, and improved git and submodule handling for more reliable builds.DOCKER_TAGformat to align with the workflow, ensuring tags are predictable and consistent across build and deployment steps.