Optimize subprocess

增加一批异常处理机制，增强代码健壮性（感谢“通义灵码”！）；

Author: muziing

src/py2exe_gui/Utilities/platform_specifc_funcs.py

@@ -7,6 +7,7 @@
 """
 
 import subprocess
+import warnings
 from pathlib import Path
 from typing import Union
 
@@ -19,13 +20,22 @@ def open_dir_in_explorer(dir_path: Union[str, Path]) -> None:
     :param dir_path: 待打开的目录路径
     """
 
-    if RUNTIME_INFO.platform == PLATFORM.windows:
-        import os  # fmt: skip
-        os.startfile(dir_path)  # type: ignore
-    elif RUNTIME_INFO.platform == PLATFORM.linux:
-        subprocess.call(["xdg-open", dir_path])
-    elif RUNTIME_INFO.platform == PLATFORM.macos:
-        subprocess.call(["open", dir_path])
+    try:
+        if RUNTIME_INFO.platform == PLATFORM.windows:
+            import os  # fmt: skip
+            os.startfile(dir_path)  # type: ignore
+        elif RUNTIME_INFO.platform == PLATFORM.linux:
+            subprocess.call(["xdg-open", dir_path])
+        elif RUNTIME_INFO.platform == PLATFORM.macos:
+            subprocess.call(["open", dir_path])
+        else:
+            raise ValueError(f"Unsupported platform: {RUNTIME_INFO.platform}.")
+    except OSError as e:
+        warnings.warn(
+            f"Error occurred while trying to open directory: {e}",
+            RuntimeWarning,
+            stacklevel=2,
+        )
 
 
 def get_sys_python() -> str:
@@ -35,10 +45,24 @@ def get_sys_python() -> str:
     """
 
     if RUNTIME_INFO.platform == PLATFORM.windows:
-        cmd = "powershell.exe (Get-Command python).Path"  # PowerShell
+        cmd = ["powershell.exe", "(Get-Command python).Path"]  # PowerShell
     elif RUNTIME_INFO.platform in (PLATFORM.linux, PLATFORM.macos):
-        cmd = "which python3"
+        cmd = ["which", "python3"]
     else:
         raise ValueError("Current OS is not supported.")
 
-    return subprocess.getoutput(cmd)
+    try:
+        result = subprocess.run(cmd, capture_output=True, text=True)
+        python_path = result.stdout.strip()
+    except subprocess.CalledProcessError as e:
+        warnings.warn(
+            f"Error occurred while trying to get system default Python interpreter: {e.output}",
+            RuntimeWarning,
+            stacklevel=2,
+        )
+        raise
+
+    if not Path(python_path).exists():
+        raise FileNotFoundError(f"Python interpreter not found: {python_path}")
+
+    return python_path

src/py2exe_gui/Utilities/python_env.py

@@ -38,8 +38,16 @@ def get_py_version(executable_path: Union[str, Path]) -> str:
         :return: Version of the Python interpreter, such as "3.11.7".
         """
 
-        cmd = f"{executable_path} -c \"import platform;print(platform.python_version(), end='')\""
-        version = subprocess.getoutput(cmd, encoding="utf-8")
+        cmd = [
+            f"{executable_path}",
+            "-c",
+            "import platform;print(platform.python_version(), end='')",
+        ]
+        try:
+            result = subprocess.run(cmd, capture_output=True, text=True)
+            version = result.stdout
+        except subprocess.CalledProcessError as e:
+            raise RuntimeError(f"Failed to get Python version: {e.output}") from e
         return version
 
     @staticmethod
@@ -50,14 +58,33 @@ def get_installed_packages(executable_path: Union[str, Path]) -> list[dict]:
         :return: 包列表，形如 [{'name': 'aiohttp', 'version': '3.9.1'}, {'name': 'aiosignal', 'version': '1.3.1'}, ...]
         """
 
-        cmd = (
-            f"{executable_path} -m pip list --format json "
-            "--disable-pip-version-check --no-color "
-            "--no-python-version-warning"
-        )
-        pip_list = subprocess.getoutput(cmd)
-        # TODO 添加异常处理机制
-        installed_packages: list[dict] = json.loads(pip_list)
+        cmd = [
+            f"{executable_path}",
+            "-m",
+            "pip",
+            "list",
+            "--format",
+            "json",
+            "--disable-pip-version-check",
+            "--no-color",
+            "--no-python-version-warning",
+        ]
+
+        try:
+            # 运行 pip list 命令，获取输出
+            result = subprocess.run(cmd, capture_output=True, text=True)
+            pip_list = result.stdout
+        except subprocess.CalledProcessError as e:
+            raise RuntimeError(f"Failed to get installed packages: {e.output}") from e
+        except Exception as e:
+            raise RuntimeError(f"An error occurred: {e}") from e
+
+        try:
+            # json 解析
+            installed_packages: list[dict] = json.loads(pip_list)
+        except json.decoder.JSONDecodeError as e:
+            raise RuntimeError(f"Failed to parse installed packages: {e}") from e
+
         return installed_packages
 
     @classmethod
@@ -70,16 +97,12 @@ def infer_type(cls, executable_path: Union[str, Path]) -> PyEnvType:
 
     def pkg_installed(self, package_name: str) -> bool:
         """
-        检索某个包是否已安装 \n
-        :param package_name: 待检索的包名
+        检查特定软件包是否已安装 \n
+        :param package_name: 待检索的软件包名称
         :return: 是否已安装
         """
 
-        for package in self.installed_packages:
-            if package["name"] == package_name:
-                return True
-        else:
-            return False
+        return any(pkg["name"] == package_name for pkg in self.installed_packages)
 
 
 if __name__ == "__main__":