Skip to content

Commit f0e1fc4

Browse files
committed
feat: house keeping
Signed-off-by: Marcos Tischer Vallim <tischer@gmail.com>
1 parent 5d09cbb commit f0e1fc4

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

amazon-sns-java-messaging-lib-template/src/main/java/com/amazon/sns/messaging/lib/concurrent/ExecutorsProvider.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,25 +37,25 @@ public final class ExecutorsProvider {
3737

3838
static {
3939
if (ExecutorsProvider.getJavaVersion() >= 21) {
40-
ExecutorsProvider.supplierExecutorService = ExecutorsProvider::getVirtualThreadExecutor;
40+
ExecutorsProvider.supplierExecutorService = ExecutorsProvider::getVirtualExecutorService;
4141
ExecutorsProvider.LOGGER.info("Java version is {}, using virtual thread executor", ExecutorsProvider.getJavaVersion());
4242
} else {
43-
ExecutorsProvider.supplierExecutorService = ExecutorsProvider::getDefaultThreadExecutor;
43+
ExecutorsProvider.supplierExecutorService = ExecutorsProvider::getDefaultExecutorService;
4444
ExecutorsProvider.LOGGER.info("Java version is {}, using default thread executor", ExecutorsProvider.getJavaVersion());
4545
}
4646
}
4747

48-
public static ExecutorService getThreadExecutor() {
48+
public static ExecutorService getExecutorService() {
4949
return ExecutorsProvider.supplierExecutorService.get();
5050
}
5151

5252
@SneakyThrows
53-
private static ExecutorService getDefaultThreadExecutor() {
53+
private static ExecutorService getDefaultExecutorService() {
5454
return Executors.newSingleThreadExecutor();
5555
}
5656

5757
@SneakyThrows
58-
private static ExecutorService getVirtualThreadExecutor() {
58+
private static ExecutorService getVirtualExecutorService() {
5959
final Class<?> clazzThread = Executors.class;
6060
final Method ofVirtualMethod = clazzThread.getMethod("newVirtualThreadPerTaskExecutor");
6161
return ExecutorService.class.cast(ofVirtualMethod.invoke(null));

amazon-sns-java-messaging-lib-template/src/test/java/com/amazon/sns/messaging/lib/concurrent/RingBufferBlockingQueueTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class RingBufferBlockingQueueTest {
4141

4242
@Test
4343
void testSuccess() {
44-
final ExecutorService producer = ExecutorsProvider.getThreadExecutor();
44+
final ExecutorService producer = ExecutorsProvider.getExecutorService();
4545

4646
final ScheduledExecutorService consumer = Executors.newSingleThreadScheduledExecutor(ThreadFactoryProvider.getThreadFactory());
4747

@@ -90,9 +90,9 @@ void testSuccess() {
9090
void testSuccessWhenIsEmpty() {
9191
final RingBufferBlockingQueue<RequestEntry<Integer>> ringBlockingQueue = new RingBufferBlockingQueue<>();
9292

93-
final ExecutorService producer = ExecutorsProvider.getThreadExecutor();
93+
final ExecutorService producer = ExecutorsProvider.getExecutorService();
9494

95-
final ExecutorService consumer = ExecutorsProvider.getThreadExecutor();
95+
final ExecutorService consumer = ExecutorsProvider.getExecutorService();
9696

9797
consumer.submit(() -> {
9898
assertThat(ringBlockingQueue.take().getValue(), is(0));
@@ -119,9 +119,9 @@ void testSuccessWhenIsEmpty() {
119119
void testSuccessWhenIsFull() {
120120
final RingBufferBlockingQueue<RequestEntry<Integer>> ringBlockingQueue = new RingBufferBlockingQueue<>(1);
121121

122-
final ExecutorService producer = ExecutorsProvider.getThreadExecutor();
122+
final ExecutorService producer = ExecutorsProvider.getExecutorService();
123123

124-
final ExecutorService consumer = ExecutorsProvider.getThreadExecutor();
124+
final ExecutorService consumer = ExecutorsProvider.getExecutorService();
125125

126126
producer.submit(() -> {
127127
ringBlockingQueue.put(RequestEntry.<Integer>builder().withValue(0).build());

amazon-sns-java-messaging-lib-v1/src/main/java/com/amazon/sns/messaging/lib/core/AmazonSnsTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ private AmazonSnsTemplate(
4141
final ObjectMapper objectMapper,
4242
final UnaryOperator<PublishBatchRequest> publishDecorator) {
4343
super(
44-
new AmazonSnsProducer<>(pendingRequests, topicRequests, ExecutorsProvider.getThreadExecutor()),
44+
new AmazonSnsProducer<>(pendingRequests, topicRequests, ExecutorsProvider.getExecutorService()),
4545
new AmazonSnsConsumer<>(amazonSnsClient, topicProperty, objectMapper, pendingRequests, topicRequests, AbstractAmazonSnsTemplate.getAmazonSnsThreadPoolExecutor(topicProperty), publishDecorator)
4646
);
4747
}

amazon-sns-java-messaging-lib-v2/src/main/java/com/amazon/sns/messaging/lib/core/AmazonSnsTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ private AmazonSnsTemplate(
4242
final ObjectMapper objectMapper,
4343
final UnaryOperator<PublishBatchRequest> publishDecorator) {
4444
super(
45-
new AmazonSnsProducer<>(pendingRequests, topicRequests, ExecutorsProvider.getThreadExecutor()),
45+
new AmazonSnsProducer<>(pendingRequests, topicRequests, ExecutorsProvider.getExecutorService()),
4646
new AmazonSnsConsumer<>(amazonSnsClient, topicProperty, objectMapper, pendingRequests, topicRequests, AbstractAmazonSnsTemplate.getAmazonSnsThreadPoolExecutor(topicProperty), publishDecorator)
4747
);
4848
}

0 commit comments

Comments
 (0)