Use int arguments in VM syscalls instead of size_t to improve safety

Author: aufau

src/qcommon/q_shared.cpp

@@ -70,7 +70,7 @@ R_RemapShader exploit
 http://ioqsrc.vampireducks.com/d8/dbe/q__shared_8c-source.html#l00061
 ============
 */
-void COM_StripExtension(const char *in, char *out, size_t destsize) {
+void COM_StripExtension(const char *in, char *out, int destsize) {
 	int length;
 	assert(out != in);
 	Q_strncpyz(out, in, destsize);

src/qcommon/q_shared.h

@@ -975,7 +975,7 @@ void PerpendicularVector( vec3_t dst, const vec3_t src );
 //=============================================
 
 char	*COM_SkipPath( char *pathname );
-void	COM_StripExtension(const char *in, char *out, size_t destsize);
+void	COM_StripExtension(const char *in, char *out, int destsize);
 void	COM_DefaultExtension( char *path, size_t maxSize, const char *extension );
 void	COM_SanitizeExtension(char *path, size_t maxSize, const char *extension);
 

src/server/server.h

@@ -280,7 +280,7 @@ void SV_RemoveOperatorCommands (void);
 void SV_MasterHeartbeat (void);
 void SV_MasterShutdown (void);
 
-qboolean MVAPI_GetConnectionlessPacket(mvaddr_t *addr, char *buf, unsigned int bufsize);
+qboolean MVAPI_GetConnectionlessPacket(mvaddr_t *addr, char *buf, int bufsize);
 qboolean MVAPI_SendConnectionlessPacket(const mvaddr_t *addr, const char *message);
 qboolean MVAPI_DisableStructConversion(qboolean disable);
 extern qboolean mvStructConversionDisabled;

src/server/sv_game.cpp

@@ -1080,7 +1080,7 @@ intptr_t SV_GameSystemCalls( intptr_t *args ) {
 			return ret;
 		}
 		case G_MVAPI_GET_CONNECTIONLESSPACKET:
-			return (int)MVAPI_GetConnectionlessPacket(VMAV(1, mvaddr_t), VMAP(2, char, (unsigned int)args[3]), (unsigned int)args[3]);
+			return (int)MVAPI_GetConnectionlessPacket(VMAV(1, mvaddr_t), VMAP(2, char, args[3]), args[3]);
 		case G_MVAPI_SEND_CONNECTIONLESSPACKET:
 			return (int)MVAPI_SendConnectionlessPacket(VMAV(1, const mvaddr_t), VMAS(2));
 		case MVAPI_CONTROL_FIXES:

src/server/sv_main.cpp

@@ -574,7 +574,7 @@ MVAPI_GetConnectionlessPacket
 */
 mvaddr_t curraddr;
 char currmessage[MAX_STRING_CHARS];
-qboolean MVAPI_GetConnectionlessPacket(mvaddr_t *addr, char *buf, unsigned int bufsize) {
+qboolean MVAPI_GetConnectionlessPacket(mvaddr_t *addr, char *buf, int bufsize) {
 	if (!mv_apiConnectionless->integer) {
 		return qtrue;
 	}