Some Android devices create unparsable backups without -nocompress flag (#75)

I see we have duplicated ADB commands between the streaming and non-steaming modes. This is not ideal as we could introduce subtle differences or bugs

Author: DonnchaC

acquisition/streaming_buffer.go

@@ -162,7 +162,7 @@ func (sp *StreamingPuller) BackupToWriter(arg string, writer io.Writer) error {
 		return fmt.Errorf("writer cannot be nil")
 	}
 
-	args := []string{"exec-out", "bu", "backup", arg}
+	args := []string{"exec-out", "bu", "backup", "-nocompress", arg}
 	if sp.serial != "" {
 		args = append([]string{"-s", sp.serial}, args...)
 	}

adb/adb.go

@@ -159,7 +159,11 @@ func (a *ADB) Push(localPath, remotePath string) (string, error) {
 // Backup generates a backup of the specified app, or of all.
 func (a *ADB) Backup(arg string) error {
 	cmd := exec.Command(a.ExePath, "backup", "-nocompress", arg)
-	return cmd.Run()
+	output, err := cmd.CombinedOutput()
+	if err != nil {
+		return fmt.Errorf("%w: %s", err, string(output))
+	}
+	return nil
 }
 
 // Bugreport generates a bugreport of the the device

modules/backup.go

@@ -75,7 +75,7 @@ func (b *Backup) Run(acq *acquisition.Acquisition, fast bool) error {
 		// Traditional mode: create backup file and move to storage directory
 		err = adb.Client.Backup(arg)
 		if err != nil {
-			log.Debugf("Impossible to get backup: %w", err)
+			log.Debugf("Impossible to get backup: %v", err)
 			return err
 		}