Handle cyclic w references - #482
Open
Isopach wants to merge 1 commit into
Open
Conversation
Track the num IDs visited during a single findLevel lookup and return null when a num ID repeats, so a cyclic w:numStyleLink chain is treated as having no resolvable level instead of recursing without bound. Adds a regression test covering a two-entry cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findLevel resolves w:numStyleLink by following the referenced numbering style to another w:num. If those references form a cycle, the lookup currently recurses until Node raises RangeError: Maximum call stack size exceeded.
This change tracks num IDs visited during a single lookup and returns null when a num ID is seen twice. A cyclic chain is therefore treated as having no resolvable level.
No behaviour change for valid documents; existing numbering tests pass unchanged.
Adds one regression test covering a two-entry w:numStyleLink cycle.