Newer devices

[squeaky-nose]

Fantastic library... however i've noticed it doesn't layout nicely on newer devices like iPhoneX. Can you please add support for X, Xr, X max, 11 and 11 Pro devices?

[sadanro100]

Did you manage to solve this?

[squeaky-nose]

Unfortunately did not. There has to be something. I think google uses something similar in Waze. Hopefully it’s open source

If you find something please let me know.

[sadanro100]

I've digged for what Waze does but I didn't find anything, it's unlikely that they use some opensource lib for this, they've probably come up with their own solution

[sadanro100]

There's this alternative, but I didn't manage to get it working in my Swift 5 project

https://github.com/yichizhang/YZKeyboardInputAccessoryView

[sadanro100]

Ended up changing the implementation to suit any device screen size

[sadanro100]

replace everything in configureKeyPositioningDefaults with:

UIScreen *screen = [UIScreen mainScreen];

CGFloat screenRatio = screen.bounds.size.width / 320;

self.keyBounds = kKeyBounds;
self.keyNormalVertOffset = -3.0f;
self.keyPressVertOffset = -2.5f;

self.leftKeyNormalHorzOffset = self.rightKeyNormalHorzOffset = 3.0f;
self.leftKeyPressHorzOffset =  -1.0f; // 2.0f no shadow
self.rightKeyPressHorzOffset = -1.0f;

self.keyCenterX = 48.0f * screenRatio;
self.keyCenterXDelta = 32.0f * screenRatio;

self.leftKeyNormalTitleEdgeInsets = self.keyNormalTitleEdgeInsets;
self.keyNormalTitleEdgeInsets = UIEdgeInsetsMake(0.0f, 0.5f, 0.0f, -0.5f);
self.rightKeyNormalTitleEdgeInsets = self.leftKeyNormalTitleEdgeInsets;

self.leftKeyPressTitleEdgeInsets = UIEdgeInsetsMake(4.0f, -5.5f, -4.0f, 5.5f);
self.keyPressTitleEdgeInsets = UIEdgeInsetsMake(4.0f, 1.0f, -4.0f, -1.0f);
self.rightKeyPressTitleEdgeInsets = UIEdgeInsetsMake(4.0f, 3.5f, -4.0f, -3.5f);

[sadanro100]

then replace everything in defaultFramePortrait with:

UIScreen *screen = [UIScreen mainScreen];
CGRect defaultFrame;

CGFloat screenRatio = screen.bounds.size.width / 320;

defaultFrame = CGRectMake(0.0f, 0.0f, 320.0f * screenRatio, 48.0f * screenRatio);
return defaultFrame;

[sadanro100]

in isRetinaHD47 replace:

result = (bounds.size.height == 667) ? YES : NO;

with

result = (bounds.size.width == 375) ? YES : NO;

[sadanro100]

in isRetinaHD55 replace:

    result = (bounds.size.height == 736 && [self respondsToSelector:@selector(scale)] && self.scale == 3) ? YES : NO;

with

    result = (bounds.size.width >= 414) ? YES : NO;

[sadanro100]

That's it

[squeaky-nose]

haha great!... I'll try it out.
Sounds like something worthy of a fork

[squeaky-nose]

Good work @sadanro100... Base scenario seems to be working with your fix above.

Theres a few issues I found around landscape. For sake of open source completeness probably worth checking those out too if you want to create a fork.

[sadanro100]

I didnt have a look at the landscape code as there was no need for landscape support in our project. I have no plans to create a fork. This was just a quick and dirty fix.

I might however port this lib to swift eventually and do stuff properly.

[sadanro100]

I didnt have a look at the landscape code as there was no need for landscape support in our project. I have no plans to create a fork. This was just a quick and dirty fix.

I might however port this lib to swift eventually and do stuff properly.

[sadanro100]

I didnt have a look at the landscape code as there was no need for landscape support in our project. I have no plans to create a fork. This was just a quick and dirty fix.

I might however port this lib to swift eventually and do stuff properly.