Minor adjustment needed for latest ember-cli-deploy-plugin, Fixes #1#2
Open
kriswill wants to merge 4 commits into
Open
Minor adjustment needed for latest ember-cli-deploy-plugin, Fixes #1#2kriswill wants to merge 4 commits into
kriswill wants to merge 4 commits into
Conversation
The pluginConfig is the bound `this` to the `deployClient` function. Also, the bound `this` doesn’t have a `this.readConfig()` but the `pluginHelper` argument does.
Author
|
@mwpastore ping. is there anything you need for this to get published? |
Owner
|
@kriswill PONG! Thank you for the patch! I am looking into general ember-cli-deploy 1.0 compatibility. I will dig into it (and probably merge this since it's so simple) over the weekend. |
ember-cli/lib/ext/promise is no longer used, and marked as deprecated.
Don't create or delete, please
Author
|
@mwpastore we still haven't been able to get to the new add-on. The problem for us is the table schema changed in the new add-on, and we have a lot of other tools and apps pointing at the table structure for the legacy add-on. I have spiked the work for the new add-on, but we are not sure if we are going to stick with using SQL to store the manifests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pluginConfig is the bound
thisto thedeployClientfunction.Also, the bound
thisdoesn’t have athis.readConfig()but thepluginHelperargument does.see #1