Fix ci, hopefully in a pretty forwards compat way

Author: mxcl

.github/workflows/checks.yml

@@ -177,7 +177,7 @@ jobs:
           action: ${{ matrix.action }}
 
   configurations:
-    runs-on: macos-13
+    runs-on: macos-latest
     needs: [verify-dist]
     strategy:
       matrix:
@@ -238,8 +238,8 @@ jobs:
           requires: ${{ matrix.x.swift }}
 
   xcode:
-    name: ${{ matrix.platform }} (${{ matrix.action }}, ${{ matrix.xcode }}${{ matrix.codecov && ', cc' || ''}}${{ matrix.job-name-sufix }})
-    runs-on: ${{ matrix.os || 'macos-latest' }}
+    name: ${{ matrix.platform }} (${{ matrix.action }} ${{ matrix.xcode }} ${{ matrix.codecov && 'cc' || ''}}${{ matrix.job-name-sufix }})
+    runs-on: macos-latest
     needs: [verify-dist]
     continue-on-error: true
     strategy:
@@ -250,29 +250,21 @@ jobs:
           - macOS
           - watchOS
         xcode:
-          - ^14
-          - ^15
+          - ^16
         codecov:
           - false
         action:
           - test
         warnings-as-errors:
           - false
         include:
-          - job-name-sufix: ', platform-version ^16'
+          - job-name-sufix: ' platform-version ^17'
             platform: iOS
-            platform-version: ^16
-            os: macos-14
+            platform-version: ^17
           - platform: mac-catalyst
             codecov: false
-            action: test
-            warnings-as-errors: false
           - platform: visionOS
-            os: macos-14
-            xcode: ^15
             codecov: false
-            action: test
-            warnings-as-errors: false
     steps:
       - uses: actions/checkout@v4
       - uses: ./
@@ -283,13 +275,13 @@ jobs:
           working-directory: fixtures/${{ matrix.platform }}
           code-coverage: ${{ matrix.codecov }}
           action: ${{ matrix.action }}
-          warnings-as-errors: ${{ matrix.warnings-as-errors }}
+          warnings-as-errors: ${{ matrix.warnings-as-errors || 'false' }}
       - run: |
           xcode-select --print-path
 
   verify-codecov:
-    name: ${{ matrix.platform }} (${{ matrix.action }}${{ matrix.codecov && ', cc' || ''}}${{ matrix.warnings-as-errors && ', warnings-as-errors' || ''}})
-    runs-on: macos-13
+    name: ${{ matrix.platform }} (${{ matrix.action }}${{ matrix.codecov && ', cc' || ''}}
+    runs-on: macos-latest
     needs: [verify-dist]
     strategy:
       matrix:
@@ -301,9 +293,6 @@ jobs:
         action:
           - build
           - test
-        warnings-as-errors:
-          # - true
-          - false
     steps:
       - uses: actions/checkout@v4
       - uses: ./
@@ -312,7 +301,6 @@ jobs:
           working-directory: fixtures/${{ matrix.platform }}
           code-coverage: ${{ matrix.codecov }}
           action: ${{ matrix.action }}
-          warnings-as-errors: ${{ matrix.warnings-as-errors }}
 
   verify-dot-swift-version:
     name: .swift-version

dist/index.js

@@ -7,7 +7,7 @@ import * as fs from 'fs'
 import semver, { Range } from 'semver'
 import type { SemVer } from 'semver'
 
-async function mdls(path: string): Promise<SemVer | undefined> {
+async function mdls(path: string): Promise<SemVer | undefined | null> {
   try {
     const v = await exec('mdls', ['-raw', '-name', 'kMDItemVersion', path])
     if (core.getInput('verbosity') == 'verbose') {
@@ -18,15 +18,30 @@ async function mdls(path: string): Promise<SemVer | undefined> {
     return semver.coerce(v) ?? undefined
   } catch (e) {
     const match = path.match(/Xcode_(.*)\.app/)
-    if (!match?.[1]) throw e
-    return semver.coerce(match[1]) ?? undefined
+    if (match?.[1]) {
+      return semver.coerce(match[1])
+    }
   }
 }
 
 async function xcodes(): Promise<[string, SemVer][]> {
-  const paths = (
-    await exec('mdfind', ['kMDItemCFBundleIdentifier = com.apple.dt.Xcode'])
-  ).split('\n')
+  const paths = await (async () => {
+    const output = await exec('mdfind', [
+      'kMDItemCFBundleIdentifier = com.apple.dt.Xcode',
+    ]).catch(() => '')
+    const rv = output
+      .split('\n')
+      .map((path) => path.trim())
+      .filter((x) => x)
+    if (rv.length == 0) {
+      for (const entry of fs.readdirSync('/Applications')) {
+        if (!/Xcode.*\.app$/.test(entry)) continue
+        rv.push(path.join('/Applications', entry))
+      }
+    }
+    return rv
+  })()
+
   const rv: [string, SemVer][] = []
   for (const path of paths) {
     if (!path.trim()) continue
@@ -35,6 +50,7 @@ async function xcodes(): Promise<[string, SemVer][]> {
       rv.push([path, v])
     }
   }
+
   return rv
 }
 
@@ -96,7 +112,12 @@ export async function xcselect(xcode?: Range, swift?: Range): Promise<SemVer> {
       .sort((a, b) => semver.compare(a[1], b[1]))
       .pop()
 
-    if (!rv3) throw new Error(`No Xcode with Swift ~> ${range}`)
+    if (!rv3)
+      throw new Error(
+        `No Xcode with Swift ~> ${range} (Xcodes: ${rv1.join(
+          ','
+        )} (Swifts: ${rv2.join(',')})`
+      )
 
     core.info(`» Selected Swift ${rv3[2]}`)