base64 encoding for payload and new redis key

Author: ReUhssurance

active_publisher.gemspec

@@ -37,5 +37,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.2"
-  spec.add_development_dependency "rspec-benchmark"
 end

lib/active_publisher/async/redis_adapter.rb

@@ -6,7 +6,7 @@
 module ActivePublisher
   module Async
     module RedisAdapter
-      REDIS_LIST_KEY = "ACTIVE_PUBLISHER_LIST".freeze
+      REDIS_LIST_KEY = "ACTIVE_PUBLISHER_LIST.V2".freeze
 
       def self.new(*args)
         ::ActivePublisher::Async::RedisAdapter::Adapter.new(*args)

lib/active_publisher/async/redis_adapter/redis_multi_pop_queue.rb

@@ -97,8 +97,6 @@ def shift(number)
 
           messages.each do |message|
             next if message.nil?
-            # TODO: This should probably attempt to ::Marshal.load and fall back to JSON for
-            # apps cutting over to new serialization.
             shifted_messages << ::ActivePublisher::Message.from_json(message)
           end
 

lib/active_publisher/message.rb

@@ -1,20 +1,27 @@
+require "base64"
 require "json"
+
 module ActivePublisher
   class Message < Struct.new(:route, :payload, :exchange_name, :options)
     class << self
       def from_json(payload)
         parsed = JSON.load(payload)
         self.new(
           parsed["route"],
-          parsed["payload"],
+          Base64.decode64(parsed["payload"]),
           parsed["exchange_name"],
           parsed["options"],
         )
       end
     end
 
     def to_json
-      self.to_h.to_json
+      {
+        route: self.route,
+        payload: Base64.encode64(self.payload),
+        exchange_name: self.exchange_name,
+        options: self.options,
+      }.to_json
     end
   end
 end

spec/lib/active_publisher/async/redis_adapter/redis_adapter_benchmark_spec.rb

@@ -4,17 +4,12 @@
 require "fakeredis/rspec"
 require "active_publisher/async/redis_adapter"
 require "connection_pool"
-require "rspec-benchmark"
 
 ::ActivePublisher::Async.publisher_adapter = ::ActivePublisher::Async::InMemoryAdapter::Adapter.new
 # Silence the logger
 $TESTING = true
 ::ActivePublisher::Logging.initialize_logger(nil)
 
-RSpec.configure do |config|
-  config.include RSpec::Benchmark::Matchers
-end
-
 def verify_expectation_within(number_of_seconds, check_every = 0.02)
   waiting_since = ::Time.now
   begin