Config is not being applied via YML files

[brianbroderick]

My Gemfile:

active_publisher (0.1.5)
  bunny (~> 2.1)
active_publisher (0.1.5-java)
  march_hare (~> 2.7)

I'm using JRuby 9.1.5.0.

Here is what the YML file looks like:

default: &default
  host: <%= ENV['RABBITMQ_HOST'] %>
  port: <%= ENV['RABBITMQ_PORT'] %>
  username: <%= ENV['RABBITMQ_USERNAME'] %>
  password: <%= ENV['RABBITMQ_PASSWORD'] %>

development:
  <<: *default

test:
  <<: *default

production:
  <<: *default

Load rails c and then run ActivePublisher.configuration

I get:

 #<ActivePublisher::Configuration:0x6e757f39 @error_handler=#<Proc:0x4e312811@/Users/brian.broderick/.rvm/gems/jruby-9.1.5.0@bellwether/gems/active_publisher-0.1.5-java/lib/active_publisher/configuration.rb:20 (lambda)>, @publisher_confirms=false, @username="guest", @virtual_host="/", @hosts=[], @heartbeat=5, @seconds_to_wait_for_graceful_shutdown=30, @port=5672, @timeout=1, @password="guest", @host="localhost">

I tried using both active_publisher.yml and action_subscriber.yml, but neither file updates the data beyond the defaults.

As a work around (or maybe the solution), I created config/initializers/active_publisher.rb with this:

::ActivePublisher.configure do |config|
  config.host     = ENV["RABBITMQ_HOST"] || "localhost"
  config.port     = ENV["RABBITMQ_PORT"] || 5672
  config.username = ENV["RABBITMQ_USERNAME"]
  config.password = ENV["RABBITMQ_PASSWORD"]
end

which seems to work.

[mmmries]

@brianbroderick I checked on how we are doing this at MX and it looks like we handle this as a railtie that is shared between our applications.

    ::ActiveSupport.on_load(:active_publisher) do
      ::ActivePublisher::Configuration.configure_from_yaml_and_cli({})
      ::ActivePublisher::Async.publisher_adapter = ::ActivePublisher::Async::InMemoryAdapter.new()
    end

I think using a config/initializer or an on_load in a gem are both good approaches to this. Do you think it should be a default behavior of the library that it tries to load its own configuration when the gem is loaded?

[brianbroderick]

Yeah. I think it should try to load its own config when the gem is loaded, if it's available. There could be a standard format for both ActivePublisher and ActionSubscriber. That way, we don't have to have the config in 2 places, but overall, it's not that big of a deal to have it twice.

I don't mind if it's in Ruby (using on_load or config/initializer) or in a yml file. Whichever way though, it should be the same for both gems for the sake of consistency.