Merge branch 'matt/remove_pom_support' into 'master'

Remove support for pom.xml

See merge request mx/binks!5

Author: mattnichols

Gemfile

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
 source "https://rubygems.org"
-source "https://gems.internal.mx"
 
 gemspec

Gemfile.lock

@@ -2,30 +2,25 @@ PATH
   remote: .
   specs:
     binks (0.0.4)
-      nokogiri (>= 1.10.4)
       thor (>= 0.20.3)
 
 GEM
   remote: https://rubygems.org/
-  remote: https://gems.internal.mx/
   specs:
     ast (2.4.0)
     coderay (1.1.2)
     diff-lcs (1.3)
     docile (1.3.2)
-    ffi (1.11.1-java)
-    jaro_winkler (1.5.3)
-    jaro_winkler (1.5.3-java)
-    json (2.2.0)
-    json (2.2.0-java)
+    ffi (1.11.3-java)
+    jaro_winkler (1.5.4)
+    jaro_winkler (1.5.4-java)
+    json (2.3.0)
+    json (2.3.0-java)
     mad_rubocop (3.64.0)
       rubocop (~> 0.64.0)
     method_source (0.9.2)
-    mini_portile2 (2.4.0)
-    nokogiri (1.10.4)
-      mini_portile2 (~> 2.4.0)
-    parallel (1.18.0)
-    parser (2.6.5.0)
+    parallel (1.19.1)
+    parser (2.7.0.2)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pry (0.12.2)
@@ -42,15 +37,15 @@ GEM
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
     rspec-expectations (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
+    rspec-support (3.9.2)
     rubocop (0.64.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
@@ -67,7 +62,7 @@ GEM
     simplecov-html (0.10.2)
     spoon (0.0.6)
       ffi
-    thor (0.20.3)
+    thor (1.0.1)
     unicode-display_width (1.4.1)
 
 PLATFORMS
@@ -85,4 +80,4 @@ DEPENDENCIES
   simplecov
 
 BUNDLED WITH
-   1.17.1
+   2.1.4

binks.gemspec

@@ -31,7 +31,7 @@ require "binks/version"
   spec.executables   = ["binks"]
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "nokogiri", ">= 1.10.4"
+  # spec.add_dependency "nokogiri", ">= 1.10.4"
   spec.add_dependency "thor",     ">= 0.20.3"
 
   spec.add_development_dependency "bundler", ">= 1.16.0"

lib/binks.rb

@@ -5,6 +5,5 @@
 require "binks/git_cli"
 require "binks/gradle"
 require "binks/jar"
-require "binks/pom"
 require "binks/version_parser"
 require "binks/version"

lib/binks/jar.rb

@@ -39,11 +39,7 @@ def git
     end
 
     def build_file
-      @build_file ||= if ::File.exist?("pom.xml")
-                        ::Binks::Pom.new("pom.xml")
-                      elsif ::File.exist?("build.gradle")
-                        ::Binks::Gradle.new("build.gradle")
-                      end
+      @build_file ||= ::Binks::Gradle.new("build.gradle")
     end
   end
 end

lib/binks/pom.rb

@@ -5,15 +5,15 @@
   let(:branch) { "master" }
   let(:all_tags) { [] }
   let(:dirty) { false }
-  let(:pom) { double(:pom, :version => ::Binks::VersionParser.new(version)) }
+  let(:build) { double(:build, :version => ::Binks::VersionParser.new(version)) }
   let(:git) { double(:git) }
 
   let(:options) { {} }
   subject { described_class.new(options) }
 
   before do
     allow(::Binks::GitCli).to receive(:new).and_return(git)
-    allow(::Binks::Pom).to receive(:new).and_return(pom)
+    allow(::Binks::Gradle).to receive(:new).and_return(build)
 
     allow(git).to receive(:current_branch).and_return(branch)
     allow(git).to receive(:all_tags).and_return(all_tags)
@@ -93,7 +93,7 @@
   describe "#version" do
     let(:version) { "0.0.2" }
 
-    it "gives version from pom" do
+    it "gives version from build" do
       expect(subject.version.to_s).to eq(version)
     end
   end