Skip to content

Commit a42a0b7

Browse files
committed
Add informative error when no valid version is detected
1 parent 48adc39 commit a42a0b7

3 files changed

Lines changed: 13 additions & 0 deletions

File tree

lib/binks/gradle.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def initialize(filename)
1212
def version
1313
@version ||= begin
1414
match = @text.match(GRADLE_VERSION)
15+
raise ::Binks::BinksError, "No valid version detected in #{@filename}" if match.nil?
1516
::Binks::VersionParser.new(match[:version])
1617
end
1718
end

spec/binks/gradle_spec.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@
2121
end
2222
end
2323

24+
context "with invalid version" do
25+
let(:build_file) { "spec/resources/build_invalid.gradle" }
26+
27+
it "loads version of with correct value" do
28+
expect { subject.version }.to raise_error ::Binks::BinksError, "No valid version detected in spec/resources/build_invalid.gradle"
29+
end
30+
end
31+
2432
it "loads version of type VersionParser" do
2533
expect(subject.version.class).to eq(::Binks::VersionParser)
2634
end
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
apply plugin: 'java'
2+
apply plugin: 'eclipse'
3+
4+
version = '0.0.1-some_invalid_junk'

0 commit comments

Comments
 (0)