Merge branch 'matt/ignore_quote_for_version_parse' into 'master'

Ignore quote for version parse

See merge request mx/binks!6

Author: mattnichols

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    binks (0.0.4)
+    binks (0.0.5)
       thor (>= 0.20.3)
 
 GEM

README.md

@@ -61,9 +61,6 @@ binks release -f
 See [process wiki page](https://gitlab.mx.com/mx/io/wikis/Gems) for details on updating a gem.
 
 1. Create your feature branch (`git checkout -b my-new-feature`)
-2. If changing a `.proto` file
-  1. `brew install protobuf` _(unless you already have it)_
-  2. `rake compile`
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request

lib/binks/gradle.rb

@@ -1,6 +1,6 @@
 module Binks
   class Gradle
-    GRADLE_VERSION = %r{version[\s]*\=[\s]*'(?<version>[\.\d]+(|\.pre))'}
+    GRADLE_VERSION = %r{version[\s]*\=[\s]*['"](?<version>[\.\d]+(|\.pre))['"]}
 
     attr_reader :filename
 
@@ -12,6 +12,7 @@ def initialize(filename)
     def version
       @version ||= begin
         match = @text.match(GRADLE_VERSION)
+        raise ::Binks::BinksError, "No valid version detected in #{@filename}" if match.nil?
         ::Binks::VersionParser.new(match[:version])
       end
     end

spec/binks/gradle_spec.rb

@@ -1,10 +1,32 @@
 require "spec_helper"
 
 describe ::Binks::Gradle do
-  subject { described_class.new("build.gradle") }
+  let(:build_file) { "spec/resources/build_single_quote.gradle" }
 
-  it "loads version of with correct value" do
-    expect("#{subject.version}").to eq("0.0.1")
+  subject { described_class.new(build_file) }
+
+  context "with single-quotes" do
+    let(:build_file) { "spec/resources/build_single_quote.gradle" }
+
+    it "loads version of with correct value" do
+      expect("#{subject.version}").to eq("0.0.1")
+    end
+  end
+
+  context "with double-quotes" do
+    let(:build_file) { "spec/resources/build_double_quote.gradle" }
+
+    it "loads version of with correct value" do
+      expect("#{subject.version}").to eq("0.0.2")
+    end
+  end
+
+  context "with invalid version" do
+    let(:build_file) { "spec/resources/build_invalid.gradle" }
+
+    it "loads version of with correct value" do
+      expect { subject.version }.to raise_error ::Binks::BinksError, "No valid version detected in spec/resources/build_invalid.gradle"
+    end
   end
 
   it "loads version of type VersionParser" do

spec/resources/build_double_quote.gradle

@@ -0,0 +1,4 @@
+apply plugin: 'java'
+apply plugin: 'eclipse'
+
+version = "0.0.2"

spec/resources/build_invalid.gradle

@@ -0,0 +1,4 @@
+apply plugin: 'java'
+apply plugin: 'eclipse'
+
+version = '0.0.1-some_invalid_junk'