fix(review): implement review suggestions

Author: codingLogan

src/redux/actions/App.js

@@ -12,5 +12,4 @@ export const setWidgetVersion = (version) => ({
 export const dispatcher = (dispatch) => ({
   markSessionTimedOut: () => dispatch({ type: ActionTypes.SESSION_IS_TIMED_OUT }),
   handleHumanEvent: () => dispatch({ type: ActionTypes.HUMAN_EVENT_HAPPENED }),
-  setWidgetVersion: (version) => dispatch(setWidgetVersion(version)),
 })

src/redux/actions/__tests__/app-test.js

@@ -13,11 +13,6 @@ describe('app Dispatcher', () => {
     expectDispatch({ type: ActionTypes.SESSION_IS_TIMED_OUT })
   })
 
-  it('should dispatch SET_WIDGET_VERSION', () => {
-    actions.setWidgetVersion('abc1234')
-    expectDispatch({ type: ActionTypes.SET_WIDGET_VERSION, payload: 'abc1234' })
-  })
-
   it('should create SET_WIDGET_VERSION action', () => {
     expect(setWidgetVersion('abc1234')).toEqual({
       type: ActionTypes.SET_WIDGET_VERSION,

src/redux/reducers/App.js

@@ -13,7 +13,7 @@ const markSessionTimedOut = (state) => ({ ...state, sessionIsTimedOut: true })
 
 const handleHumanEvent = (state) => ({ ...state, humanEvent: true })
 
-const setWidgetVersion = (state, action) => ({ ...state, version: action.payload || null })
+const setWidgetVersion = (state, action) => ({ ...state, version: action.payload })
 
 export const app = (state = defaultState, action) => {
   switch (action.type) {

src/redux/reducers/__tests__/app-test.js

@@ -1,7 +1,7 @@
-import { ActionTypes } from 'src/redux/actions/App'
+import { ActionTypes, setWidgetVersion } from 'src/redux/actions/App'
 import { app as reducer, defaultState } from 'src/redux/reducers/App'
 
-const { SESSION_IS_TIMED_OUT, SET_WIDGET_VERSION } = ActionTypes
+const { SESSION_IS_TIMED_OUT } = ActionTypes
 
 describe('app reducers', () => {
   it('should return the initial state', () => {
@@ -18,9 +18,7 @@ describe('app reducers', () => {
 
   describe('SET_WIDGET_VERSION', () => {
     it('should store the widget version', () => {
-      const action = { type: SET_WIDGET_VERSION, payload: 'abc1234' }
-
-      expect(reducer(undefined, action).version).toBe('abc1234')
+      expect(reducer(undefined, setWidgetVersion('abc1234')).version).toBe('abc1234')
     })
   })
 })