recording uploading is working. trying to fix some errors

Author: wesrisenmay-mx

.github/workflows/e2e-tests.yml

@@ -120,18 +120,33 @@ jobs:
             maestro test ./example/maestro/ --format junit --output example/maestro-results.xml --debug-output example/maestro-output/debug --test-output-dir example/maestro-output/debug || true
             # Attempt to record each Flow file individually (maestro record accepts a single flow file)
             bash -lc 'for f in ./example/maestro/*.yaml ./example/maestro/*.yml ./example/maestro/*.flow; do if [ -f "$f" ]; then echo "Recording $f"; maestro record --local "$f" "example/maestro-output/$(basename "$f").mp4" --debug-output example/maestro-output/debug || echo "record failed for $f"; fi; done' || true
-            # If Maestro wrote to the user home tests dir, copy those into the output dir for upload
-            if [ -d "$HOME/.maestro/tests" ]; then
-              mkdir -p example/maestro-output/.maestro-tests
-              rsync -a "$HOME/.maestro/tests/" example/maestro-output/.maestro-tests/ || true
-            fi
             echo "Listing example/maestro-output contents:"; ls -la example/maestro-output || true
             if [ -d example/maestro-output ]; then
               echo "Creating tarball example/maestro-output.tar.gz"
               tar -czf example/maestro-output.tar.gz -C example maestro-output || true
             fi
             ls -la example/ || true
 
+      - name: Collect Maestro artifacts
+        if: always()
+        run: |
+          echo "Waiting for recordings to flush"
+          sleep 2
+          sync || true
+          mkdir -p example/maestro-output/.maestro-tests
+          if [ -d "$HOME/.maestro/tests" ]; then
+            echo "Copying $HOME/.maestro/tests -> example/maestro-output/.maestro-tests/"
+            rsync -a "$HOME/.maestro/tests/" example/maestro-output/.maestro-tests/ || true
+          else
+            echo "No $HOME/.maestro/tests directory found"
+          fi
+          echo "Listing example/maestro-output contents:"; ls -la example/maestro-output || true
+          if [ -d example/maestro-output ]; then
+            echo "Creating tarball example/maestro-output.tar.gz"
+            tar -czf example/maestro-output.tar.gz -C example maestro-output || true
+          fi
+          ls -la example/ || true
+
       - name: Upload Maestro test results
         if: always()
         uses: actions/upload-artifact@v4