[ISSUE #8086]♻️Mark common logging helpers as compatibility-only#8087
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (34)
WalkthroughThree public logger initialization functions in rocketmq-common/src/log.rs are marked deprecated in favor of rocketmq_observability::logging::install_global, and WORKER_GUARD documentation is clarified as compatibility-only. Numerous example files across rocketmq-client and rocketmq-example add #[allow(deprecated)] before #[rocketmq::main] entrypoints to suppress resulting warnings. ChangesLegacy logging deprecation and example warning suppression
Estimated code review effort: 1 (Trivial) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
Which Issue(s) This PR Fixes(Closes)
Brief Description
This PR marks the legacy
rocketmq-common::loginitialization helpers as compatibility-only APIs.Changes include:
init_logger,init_logger_with_level, andinit_logger_with_filewith guidance to userocketmq_observability::logging::install_globalandTelemetryBootstrapConfig.rocketmq-observability.rocketmq-common -> rocketmq-observabilitydependency or new OpenTelemetry runtime behavior torocketmq-common.How Did You Test This Change?
cargo fmt --allpassed.cargo test -p rocketmq-common logpassed.cargo clippy -p rocketmq-client-rust --examples --all-features -- -D warningspassed.cargo clippy --workspace --no-deps --all-targets --all-features -- -D warningspassed.rocketmq-example/,cargo fmt --allpassed.rocketmq-example/,cargo clippy --all-targets -- -D warningspassed.Summary by CodeRabbit
Bug Fixes
Documentation