[ISSUE #8096]♻️Replace legacy logger setup in root examples#8097
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
Which Issue(s) This PR Fixes(Closes)
Brief Description
This PR removes legacy logger bootstrap patterns from root workspace examples and routes them through the unified telemetry bootstrap.
Changes include:
rocketmq_common::log::init_loggerin root workspace client examples withrocketmq_observability::install_global.tracing_subscribersetup in controller and scheduler examples with the unified bootstrap.rocketmq-rustexample dev dependency fromtracing-subscribertorocketmq-observability.rocketmq-exampleuntouched because it is a separate project with its own validation boundary.How Did You Test This Change?
cargo fmt --allpassed.cargo test -p rocketmq-rust --examples --all-featurespassed.cargo test -p rocketmq-client-rust --examples --all-featurespassed.cargo test -p rocketmq-controller --examples --all-featurespassed.cargo clippy --workspace --no-deps --all-targets --all-features -- -D warningspassed.