[ISSUE #8098]♻️Use telemetry bootstrap in standalone examples#8099
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
WalkthroughThe rocketmq-example crate adds a dev-dependency on rocketmq-observability. Across 21 consumer, producer, and interop example binaries, logger initialization via rocketmq_common::log::init_logger is replaced with rocketmq_observability::install_global telemetry bootstrap, with an explicit telemetry_guard.shutdown() call added before each example completes. ChangesTelemetry bootstrap adoption in examples
Estimated code review effort: 2 (Simple) | ~12 minutes Sequence Diagram(s)sequenceDiagram
participant Main
participant TelemetryGuard as rocketmq_observability
participant Component as Consumer/Producer
Main->>TelemetryGuard: install_global(config)
TelemetryGuard-->>Main: telemetry_guard
Main->>Component: start / run example logic
Component-->>Main: completion / shutdown signal
Main->>Component: shutdown()
Main->>TelemetryGuard: telemetry_guard.shutdown()
Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
Which Issue(s) This PR Fixes(Closes)
Brief Description
This PR migrates the standalone example project away from the compatibility logger and into the unified telemetry bootstrap.
Changes include:
rocketmq-observabilityas a dev dependency for the standalone example project.rocketmq_common::log::init_loggerin standalone consumer, producer, and interop examples.How Did You Test This Change?
cargo fmt --allpassed fromrocketmq-example.cargo clippy --all-targets -- -D warningspassed fromrocketmq-example.Summary by CodeRabbit
New Features
Chores