Skip to content

[ISSUE #8114]🐛Stabilize tieredstore read fallback query test#8115

Merged
rocketmq-rust-bot merged 1 commit into
mainfrom
mxsm/fix-tieredstore-read-fallback-query-test
Jul 8, 2026
Merged

[ISSUE #8114]🐛Stabilize tieredstore read fallback query test#8115
rocketmq-rust-bot merged 1 commit into
mainfrom
mxsm/fix-tieredstore-read-fallback-query-test

Conversation

@mxsm

@mxsm mxsm commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Which Issue(s) This PR Fixes(Closes)

Brief Description

Disables tiered file deletion for the tieredstore_read_path_falls_back_when_local_queue_is_missing test. The test uses a synthetic old store timestamp and verifies read/query fallback behavior, not cleanup; keeping cleanup enabled let the zero-delay cleanup scheduler remove the tiered index before query fallback assertions on busy runners.

How Did You Test This Change?

  • cargo test -p rocketmq-store --lib message_store::local_file_message_store::tests::tieredstore_read_path_falls_back_when_local_queue_is_missing --all-features -- --nocapture - passed.
  • cargo fmt --all - passed.
  • cargo test -p rocketmq-store --lib --all-features - passed, 623 tests.
  • cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings - passed.

Summary by CodeRabbit

  • Tests
    • Updated a storage fallback test setup to better reflect scenarios where local data is unavailable.

@rocketmq-rust-robot rocketmq-rust-robot added the bug🐛 Something isn't working label Jul 8, 2026
@rocketmq-rust-bot

Copy link
Copy Markdown
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1e5b515e-6d76-4f4b-836e-637ed097b6e3

📥 Commits

Reviewing files that changed from the base of the PR and between 280da30 and 577b666.

📒 Files selected for processing (1)
  • rocketmq-store/src/message_store/local_file_message_store.rs

Walkthrough

A test-only configuration change sets delete_file_enable: false in the TieredStoreConfig used by the tieredstore_read_path_falls_back_when_local_queue_is_missing unit test, preventing tiered store cleanup from racing with the fallback query assertion.

Changes

Tiered store test stabilization

Layer / File(s) Summary
Disable file deletion in test config
rocketmq-store/src/message_store/local_file_message_store.rs
Sets delete_file_enable: false in the test's TieredStoreConfig to avoid intermittent failures caused by cleanup racing with the query fallback assertion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • mxsm/rocketmq-rust#7863: Both PRs modify the same tieredstore_read_path_falls_back_when_local_queue_is_missing test to stabilize its fallback query behavior.
  • mxsm/rocketmq-rust#7328: Introduces/expands the tiered-store integration in local_file_message_store.rs that this test configuration change targets.

Suggested labels: area/store

Suggested reviewers: SpaceXCN, TeslaRustor, rocketmq-rust-bot

Poem

A tiny flag, a quiet fix,
No more cleanup's naughty tricks,
The fallback query sleeps at ease,
While files stay put, no race to tease,
Hop, hop, hooray — the tests now please! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: stabilizing the tieredstore read fallback test.
Linked Issues check ✅ Passed The change matches #8114 by disabling tiered file deletion in the test-only store config to avoid cleanup races.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to the requested test stabilization and adds no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mxsm/fix-tieredstore-read-fallback-query-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.41%. Comparing base (81b23ee) to head (577b666).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8115      +/-   ##
==========================================
- Coverage   70.44%   70.41%   -0.04%     
==========================================
  Files        1261     1261              
  Lines      282379   282380       +1     
==========================================
- Hits       198933   198832     -101     
- Misses      83446    83548     +102     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

@rocketmq-rust-bot rocketmq-rust-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All CI checks passed ✅

@rocketmq-rust-bot rocketmq-rust-bot merged commit 02746eb into main Jul 8, 2026
28 of 29 checks passed
@rocketmq-rust-bot rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge bug🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug🐛] Stabilize tieredstore read fallback query test

3 participants