[ISSUE #8114]🐛Stabilize tieredstore read fallback query test#8115
Conversation
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA test-only configuration change sets ChangesTiered store test stabilization
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8115 +/- ##
==========================================
- Coverage 70.44% 70.41% -0.04%
==========================================
Files 1261 1261
Lines 282379 282380 +1
==========================================
- Hits 198933 198832 -101
- Misses 83446 83548 +102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rocketmq-rust-bot
left a comment
There was a problem hiding this comment.
LGTM - All CI checks passed ✅
rocketmq-rust-bot
left a comment
There was a problem hiding this comment.
LGTM - All CI checks passed ✅
Which Issue(s) This PR Fixes(Closes)
Brief Description
Disables tiered file deletion for the
tieredstore_read_path_falls_back_when_local_queue_is_missingtest. The test uses a synthetic old store timestamp and verifies read/query fallback behavior, not cleanup; keeping cleanup enabled let the zero-delay cleanup scheduler remove the tiered index before query fallback assertions on busy runners.How Did You Test This Change?
cargo test -p rocketmq-store --lib message_store::local_file_message_store::tests::tieredstore_read_path_falls_back_when_local_queue_is_missing --all-features -- --nocapture- passed.cargo fmt --all- passed.cargo test -p rocketmq-store --lib --all-features- passed, 623 tests.cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings- passed.Summary by CodeRabbit