updates migrating off global tf handler to the MyAdminApp class handler

Author: detain

bin/activate_fantastico.php

@@ -2,9 +2,9 @@
 <?php
 
 require_once __DIR__.'/../../../../include/functions.inc.php';
-$GLOBALS['tf']->session->create(160308, 'services');
-$GLOBALS['tf']->session->verify();
+\MyAdmin\App::session()->create(160308, 'services');
+\MyAdmin\App::session()->verify();
 
 activate_fantastico('66.23.229.238', 2);
 
-$GLOBALS['tf']->session->destroy();
+\MyAdmin\App::session()->destroy();

bin/fantastico_licenses.php

@@ -5,4 +5,4 @@
 
 print_r(get_fantastico_licenses());
 
-//$GLOBALS['tf']->session->destroy();
+//\MyAdmin\App::session()->destroy();

src/Plugin.php

@@ -75,7 +75,7 @@ public static function getChangeIp(GenericEvent $event)
                 $event['status'] = 'error';
                 $event['status_text'] = 'Error Code '.$result['faultcode'].': '.$result['fault'];
             } else {
-                $GLOBALS['tf']->history->add($settings['TABLE'], 'change_ip', $event['newip'], $serviceClass->getId(), $serviceClass->getCustid());
+                \MyAdmin\App::history()->add($settings['TABLE'], 'change_ip', $event['newip'], $serviceClass->getId(), $serviceClass->getCustid());
                 $serviceClass->set_ip($event['newip'])->save();
                 $event['status'] = 'ok';
                 $event['status_text'] = 'The IP Address has been changed.';
@@ -90,7 +90,7 @@ public static function getChangeIp(GenericEvent $event)
     public static function getMenu(GenericEvent $event)
     {
         $menu = $event->getSubject();
-        if ($GLOBALS['tf']->ima == 'admin') {
+        if (\MyAdmin\App::ima() == 'admin') {
             $menu->add_link(self::$module, 'choice=none.reusable_fantastico', '/images/myadmin/replicate-rows.png', _('ReUsable Fantastico Licenses'));
             $menu->add_link(self::$module, 'choice=none.fantastico_list', '/images/myadmin/active-directory.png', _('Fantastico Licenses Breakdown'));
             $menu->add_link(self::$module.'api', 'choice=none.fantastico_licenses_list', '/images/myadmin/list.png', _('List all Fantastico Licenses'));

src/fantastico_licenses_list.php

@@ -11,7 +11,7 @@
 
 function fantastico_licenses_list()
 {
-    if ($GLOBALS['tf']->ima == 'admin') {
+    if (\MyAdmin\App::ima() == 'admin') {
         $table = new \TFTable();
         $table->set_title('Fantastico License List');
         $header = false;

src/fantastico_list.php

@@ -11,7 +11,7 @@
 
 function fantastico_list()
 {
-    if ($GLOBALS['tf']->ima == 'admin') {
+    if (\MyAdmin\App::ima() == 'admin') {
         page_title('Fantastico License List');
         add_output(render_form('fantastico_list'));
     }

src/reusable_fantastico.php

@@ -19,16 +19,16 @@
 function reusable_fantastico()
 {
     page_title('ReUsable Fantastico Licenses');
-    if ($GLOBALS['tf']->ima == 'admin') {
+    if (\MyAdmin\App::ima() == 'admin') {
         $module = 'licenses';
         $serviceTypes = run_event('get_service_types', false, $module);
         $db = get_module_db($module);
         $settings = \get_module_settings($module);
         $fantastico = new Fantastico(FANTASTICO_USERNAME, FANTASTICO_PASSWORD);
         $ips = $fantastico->getIpList(Fantastico::ALL_TYPES);
         $frequency = 1;
-        if (isset($GLOBALS['tf']->variables->request['add']) && $GLOBALS['tf']->variables->request['add'] == 1) {
-            $ipAddress = $db->real_escape($GLOBALS['tf']->variables->request['ip']);
+        if (isset(\MyAdmin\App::variables()->request['add']) && \MyAdmin\App::variables()->request['add'] == 1) {
+            $ipAddress = $db->real_escape(\MyAdmin\App::variables()->request['ip']);
             if (in_array($ipAddress, $ips)) {
                 $db->query("select * from {$settings['TABLE']} left join services on {$settings['PREFIX']}_type=services_id where services_module='{$module}' and services_category=".get_service_define('FANTASTICO')." and license_ip='{$ipAddress}'", __LINE__, __FILE__);
                 if ($db->num_rows() == 0) {

tests/SourceFileAnalysisTest.php

@@ -300,7 +300,7 @@ public function testLicensesListFileDefinesFunction(): void
     public function testLicensesListChecksAdmin(): void
     {
         $content = file_get_contents(self::$srcDir . '/fantastico_licenses_list.php');
-        $this->assertStringContainsString("\$GLOBALS['tf']->ima == 'admin'", $content);
+        $this->assertStringContainsString("\\MyAdmin\App::ima() == 'admin'", $content);
     }
 
     /**
@@ -341,7 +341,7 @@ public function testListFileDefinesFunction(): void
     public function testListChecksAdmin(): void
     {
         $content = file_get_contents(self::$srcDir . '/fantastico_list.php');
-        $this->assertStringContainsString("\$GLOBALS['tf']->ima == 'admin'", $content);
+        $this->assertStringContainsString("\\MyAdmin\App::ima() == 'admin'", $content);
     }
 
     /**
@@ -391,7 +391,7 @@ public function testReusableFileDefinesFunction(): void
     public function testReusableChecksAdmin(): void
     {
         $content = file_get_contents(self::$srcDir . '/reusable_fantastico.php');
-        $this->assertStringContainsString("\$GLOBALS['tf']->ima == 'admin'", $content);
+        $this->assertStringContainsString("\\MyAdmin\App::ima() == 'admin'", $content);
     }
 
     /**