Skip to content

Commit 44f030f

Browse files
committed
refactor(telemetry): remove DEBUG conditional compilation
1 parent 3ac5975 commit 44f030f

File tree

4 files changed

+1
-11
lines changed

4 files changed

+1
-11
lines changed

src/HttpUserAgentParser/Telemetry/HttpUserAgentParserMeters.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ public static void Enable(Meter? meter = null)
109109
[MethodImpl(MethodImplOptions.AggressiveInlining)]
110110
public static void ConcurrentCacheMiss() => s_concurrentCacheMiss?.Add(1);
111111

112-
#if DEBUG
113112
/// <summary>
114113
/// Resets static state to support isolated unit tests.
115114
/// </summary>
@@ -124,5 +123,4 @@ public static void ResetForTests()
124123
s_concurrentCacheMiss = null;
125124
s_concurrentCacheSize = null;
126125
}
127-
#endif
128126
}

src/HttpUserAgentParser/Telemetry/HttpUserAgentParserTelemetry.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,13 @@ public static void ConcurrentCacheMiss()
152152
public static void ConcurrentCacheSizeSet(int size)
153153
=> HttpUserAgentParserTelemetryState.SetConcurrentCacheSize(size);
154154

155-
#if DEBUG
156155
/// <summary>
157-
/// Resets static state to support isolated unit tests.
156+
/// Resets telemetry state for unit testing.
158157
/// </summary>
159158
public static void ResetForTests()
160159
{
161160
Volatile.Write(ref s_enabledFlags, 0);
162161
HttpUserAgentParserTelemetryState.ResetForTests();
163162
HttpUserAgentParserMeters.ResetForTests();
164163
}
165-
#endif
166164
}

src/HttpUserAgentParser/Telemetry/HttpUserAgentParserTelemetryState.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ public static long ConcurrentCacheSize
3030
public static void SetConcurrentCacheSize(int size)
3131
=> Volatile.Write(ref s_concurrentCacheSize, size);
3232

33-
#if DEBUG
3433
/// <summary>
3534
/// Resets the telemetry state for unit tests.
3635
/// </summary>
3736
public static void ResetForTests()
3837
=> Volatile.Write(ref s_concurrentCacheSize, 0);
39-
#endif
4038
}

tests/HttpUserAgentParser.UnitTests/Telemetry/HttpUserAgentParserMetersTelemetryTests.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ public class HttpUserAgentParserMetersTelemetryTests
1313
[Fact]
1414
public void Meters_DoNotEmit_WhenDisabled()
1515
{
16-
#if DEBUG
1716
HttpUserAgentParserTelemetry.ResetForTests();
18-
#endif
1917

2018
using MeterTestListener listener = new(MyCSharp.HttpUserAgentParser.Telemetry.HttpUserAgentParserMeters.MeterName);
2119

@@ -28,9 +26,7 @@ public void Meters_DoNotEmit_WhenDisabled()
2826
[Fact]
2927
public void Meters_Emit_WhenEnabled()
3028
{
31-
#if DEBUG
3229
HttpUserAgentParserTelemetry.ResetForTests();
33-
#endif
3430

3531
using MeterTestListener listener = new(MyCSharp.HttpUserAgentParser.Telemetry.HttpUserAgentParserMeters.MeterName);
3632

0 commit comments

Comments
 (0)