Skip to content

Commit 58bf7c5

Browse files
committed
refactor(tests): standardize meter names in telemetry tests
1 parent 1a109d0 commit 58bf7c5

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

tests/HttpUserAgentParser.AspNetCore.UnitTests/Telemetry/HttpUserAgentParserAspNetCoreMetersTelemetryTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using Microsoft.AspNetCore.Http;
44
using Microsoft.Extensions.DependencyInjection;
55
using MyCSharp.HttpUserAgentParser.AspNetCore.DependencyInjection;
6-
using MyCSharp.HttpUserAgentParser.AspNetCore.Telemetry;
76
using MyCSharp.HttpUserAgentParser.DependencyInjection;
87
using Xunit;
98

@@ -14,7 +13,7 @@ public class HttpUserAgentParserAspNetCoreMetersTelemetryTests
1413
[Fact]
1514
public void Meters_Emit_WhenEnabled()
1615
{
17-
using MeterTestListener listener = new("MyCSharp.HttpUserAgentParser.AspNetCore");
16+
using MeterTestListener listener = new("mycsharp.http_user_agent_parser.aspnetcore");
1817

1918
new HttpUserAgentParserDependencyInjectionOptions(new ServiceCollection())
2019
.WithAspNetCoreMeterTelemetry();

tests/HttpUserAgentParser.MemoryCache.UnitTests/Telemetry/HttpUserAgentParserMemoryCacheMetersTelemetryTests.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
using Microsoft.Extensions.DependencyInjection;
44
using MyCSharp.HttpUserAgentParser.DependencyInjection;
5-
using MyCSharp.HttpUserAgentParser.MemoryCache;
65
using MyCSharp.HttpUserAgentParser.MemoryCache.DependencyInjection;
7-
using MyCSharp.HttpUserAgentParser.MemoryCache.Telemetry;
86
using Xunit;
97

108
namespace MyCSharp.HttpUserAgentParser.MemoryCache.UnitTests.Telemetry;
@@ -14,7 +12,7 @@ public class HttpUserAgentParserMemoryCacheMetersTelemetryTests
1412
[Fact]
1513
public void Meters_Emit_WhenEnabled()
1614
{
17-
using MeterTestListener listener = new("MyCSharp.HttpUserAgentParser.MemoryCache");
15+
using MeterTestListener listener = new("mycsharp.http_user_agent_parser.memorycache");
1816

1917
new HttpUserAgentParserDependencyInjectionOptions(new ServiceCollection())
2018
.WithMemoryCacheMeterTelemetry();

tests/HttpUserAgentParser.UnitTests/Telemetry/HttpUserAgentParserMetersTelemetryTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public void Meters_Emit_WhenEnabled()
2828
{
2929
HttpUserAgentParserTelemetry.ResetForTests();
3030

31-
using MeterTestListener listener = new(MyCSharp.HttpUserAgentParser.Telemetry.HttpUserAgentParserMeters.MeterName);
31+
using MeterTestListener listener = new("mycsharp.http_user_agent_parser");
3232

3333
new HttpUserAgentParserDependencyInjectionOptions(new ServiceCollection())
3434
.WithMeterTelemetry();
@@ -45,9 +45,9 @@ public void Meters_Emit_WhenEnabled()
4545

4646
Assert.Contains("parse.requests", listener.InstrumentNames);
4747
Assert.Contains("parse.duration", listener.InstrumentNames);
48-
Assert.Contains("cache.concurrent_dictionary.hit", listener.InstrumentNames);
49-
Assert.Contains("cache.concurrent_dictionary.miss", listener.InstrumentNames);
50-
Assert.Contains("cache.concurrent_dictionary.size", listener.InstrumentNames);
48+
Assert.Contains("cache.hit", listener.InstrumentNames);
49+
Assert.Contains("cache.miss", listener.InstrumentNames);
50+
Assert.Contains("cache.size", listener.InstrumentNames);
5151

5252
Assert.Equal("s", listener.InstrumentUnits["parse.duration"]);
5353
}

0 commit comments

Comments
 (0)