fix: filter boolean values from trusted-committers allowlist

rnetser · rnetser · commit bfe7557416a9 · 2026-06-16T13:34:48.000+03:00
Python's bool is a subclass of int, so YAML true/false would pass
the isinstance(entry, (str, int, float)) check and become
"true"/"false" strings in the allowlist. Added explicit bool
exclusion.

Assisted-by: Claude &lt;noreply@anthropic.com&gt;
Signed-off-by: rnetser &lt;rnetser@redhat.com&gt;
diff --git a/webhook_server/libs/github_api.py b/webhook_server/libs/github_api.py
@@ -1002,7 +1002,7 @@ def _repo_data_from_config(self, repository_config: dict[str, Any]) -> None:
         self.security_trusted_committers: list[str] = [
             str(entry).strip().lower()
             for entry in _trusted_committers
-            if isinstance(entry, (str, int, float)) and str(entry).strip()
+            if isinstance(entry, (str, int, float)) and not isinstance(entry, bool) and str(entry).strip()
         ]
 
         _auto_merge_prs = self.config.get_value(

Original file line number	Diff line number	Diff line change
`@@ -1002,7 +1002,7 @@ def _repo_data_from_config(self, repository_config: dict[str, Any]) -> None:`
`1002`	`1002`	`self.security_trusted_committers: list[str] = [`
`1003`	`1003`	`str(entry).strip().lower()`
`1004`	`1004`	`for entry in _trusted_committers`
`1005`		`- if isinstance(entry, (str, int, float)) and str(entry).strip()`
	`1005`	`+ if isinstance(entry, (str, int, float)) and not isinstance(entry, bool) and str(entry).strip()`
`1006`	`1006`	`]`
`1007`	`1007`
`1008`	`1008`	`_auto_merge_prs = self.config.get_value(`