Skip to content

Commit 59408e4

Browse files
committed
Simplify test module docstring per review feedback
Drop the detailed description from the test_management.py docstring, keeping only the general module-level summary.
1 parent d5c3f18 commit 59408e4

1 file changed

Lines changed: 29 additions & 13 deletions

File tree

tests/unit/cqlengine/test_management.py

Lines changed: 29 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright DataStax, Inc.
1+
# Copyright 2025 ScyllaDB, Inc.
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -14,10 +14,6 @@
1414

1515
"""
1616
Unit tests for cassandra.cqlengine.management module.
17-
18-
Focuses on verifying that _get_table_metadata gracefully handles missing
19-
table metadata by forcing a targeted refresh and retrying, and that
20-
_sync_table delegates to _get_table_metadata for post-DDL metadata lookup.
2117
"""
2218

2319
import unittest
@@ -114,14 +110,24 @@ def _make_model(self, ks="test_ks", table="test_table"):
114110
return model
115111

116112
@patch("cassandra.cqlengine.management._get_table_metadata")
117-
@patch("cassandra.cqlengine.management._get_create_table", return_value="CREATE TABLE test")
113+
@patch(
114+
"cassandra.cqlengine.management._get_create_table",
115+
return_value="CREATE TABLE test",
116+
)
118117
@patch("cassandra.cqlengine.management.execute")
119118
@patch("cassandra.cqlengine.management.get_cluster")
120-
@patch("cassandra.cqlengine.management._allow_schema_modification", return_value=True)
119+
@patch(
120+
"cassandra.cqlengine.management._allow_schema_modification", return_value=True
121+
)
121122
@patch("cassandra.cqlengine.management.issubclass", return_value=True)
122123
def test_calls_get_table_metadata_after_create(
123-
self, mock_issubclass, mock_allow, mock_get_cluster,
124-
mock_execute, mock_create, mock_get_meta
124+
self,
125+
mock_issubclass,
126+
mock_allow,
127+
mock_get_cluster,
128+
mock_execute,
129+
mock_create,
130+
mock_get_meta,
125131
):
126132
"""After creating a new table, _sync_table calls _get_table_metadata."""
127133
table_meta = MockTableMeta()
@@ -139,14 +145,24 @@ def test_calls_get_table_metadata_after_create(
139145
mock_get_meta.assert_called_once_with(model, None)
140146

141147
@patch("cassandra.cqlengine.management._get_table_metadata")
142-
@patch("cassandra.cqlengine.management._get_create_table", return_value="CREATE TABLE test")
148+
@patch(
149+
"cassandra.cqlengine.management._get_create_table",
150+
return_value="CREATE TABLE test",
151+
)
143152
@patch("cassandra.cqlengine.management.execute")
144153
@patch("cassandra.cqlengine.management.get_cluster")
145-
@patch("cassandra.cqlengine.management._allow_schema_modification", return_value=True)
154+
@patch(
155+
"cassandra.cqlengine.management._allow_schema_modification", return_value=True
156+
)
146157
@patch("cassandra.cqlengine.management.issubclass", return_value=True)
147158
def test_propagates_exception_from_get_table_metadata(
148-
self, mock_issubclass, mock_allow, mock_get_cluster,
149-
mock_execute, mock_create, mock_get_meta
159+
self,
160+
mock_issubclass,
161+
mock_allow,
162+
mock_get_cluster,
163+
mock_execute,
164+
mock_create,
165+
mock_get_meta,
150166
):
151167
"""CQLEngineException from _get_table_metadata propagates out of _sync_table."""
152168
mock_get_meta.side_effect = CQLEngineException("Table metadata not available")

0 commit comments

Comments
 (0)