Fix Windows hook cleanup after disable

Author: mylee04

scripts/install-windows.ps1

@@ -661,6 +661,24 @@ function Remove-ManagedClaudeHookEntries {
     return ,$result
 }
 
+function Get-ObjectPropertyNames {
+    param([object]$Object)
+
+    if ($null -eq $Object) {
+        return @()
+    }
+
+    if ($Object -is [System.Collections.IDictionary]) {
+        return @($Object.Keys)
+    }
+
+    return @(
+        $Object.PSObject.Properties |
+            Where-Object { $_.MemberType -eq "NoteProperty" } |
+            ForEach-Object { $_.Name }
+    )
+}
+
 function Update-ClaudeSettingsHooks {
     param(
         [object]$Settings,
@@ -720,7 +738,7 @@ function Update-ClaudeSettingsHooks {
         $Settings.hooks.PSObject.Properties.Remove("Stop")
     }
 
-    if ($Settings.hooks.PSObject.Properties.Count -eq 0) {
+    if ((Get-ObjectPropertyNames $Settings.hooks).Count -eq 0) {
         $Settings.PSObject.Properties.Remove("hooks")
     }
 
@@ -1020,7 +1038,7 @@ function Disable-Notifications {
             $settings = Get-Content $settingsFile -Raw | ConvertFrom-Json -ErrorAction SilentlyContinue
             if ($settings -and $settings.hooks) {
                 $settings = Update-ClaudeSettingsHooks -Settings $settings -NotifyScript (Get-NotifyScript) -Disable
-                if ($settings.PSObject.Properties.Count -eq 0) {
+                if ((Get-ObjectPropertyNames $settings).Count -eq 0) {
                     Remove-Item $settingsFile -Force -ErrorAction SilentlyContinue
                 } else {
                     $settings | ConvertTo-Json -Depth 10 | Set-Content $settingsFile -Encoding UTF8

tests/test-windows-claude-hook-preservation.sh

@@ -117,6 +117,22 @@ try {
     if (Test-HookEntriesContainCommand -Entries @($settings.hooks.Notification) -Matcher "idle_prompt" -Command $notifyCommand) {
         throw "managed Notification hook should be removed during disable"
     }
+
+    Remove-Item $script:SettingsFile -Force -ErrorAction SilentlyContinue
+
+    Enable-Notifications -Tool "claude"
+    $settings = Get-Content $script:SettingsFile -Raw | ConvertFrom-Json -ErrorAction Stop
+    if (-not $settings.hooks) {
+        throw "managed hooks were not created for the clean settings case"
+    }
+
+    Disable-Notifications -Tool "claude"
+    if (Test-Path $script:SettingsFile) {
+        $settings = Get-Content $script:SettingsFile -Raw | ConvertFrom-Json -ErrorAction Stop
+        if ($settings.hooks) {
+            throw "hooks should be removed entirely when only managed Claude hooks existed"
+        }
+    }
 }
 finally {
     Remove-Item $testRoot -Recurse -Force -ErrorAction SilentlyContinue