fix(script): When no item is selected from the clipboard history, the…#1738
Open
martinpiz097 wants to merge 1 commit into
Open
fix(script): When no item is selected from the clipboard history, the…#1738martinpiz097 wants to merge 1 commit into
martinpiz097 wants to merge 1 commit into
Conversation
… currently loaded item is no longer deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the clipboard history script behavior when no item is selected from the menu.
Changes
Context
When the clipboard history menu was invoked and the user closed it without selecting any item, the currently loaded clipboard content was overwritten with an empty value. This caused the previously copied text to be lost, forcing the user to reopen the history and select it again. Now, if no item is selected from the menu, the script exits cleanly without modifying the clipboard.
How Has This Been Tested?
Checklist
Additional Notes
The fix was applied by capturing the rofi selection into a variable and checking whether it is empty before piping it to
cliphist decode | wl-copyorcliphist delete. If the selection is empty, the script exits with code 0.