Trap EXIT to deregister runner when runner exits by itself

[jonathan528i]

Currently, if the runner application crashes or exits natively with an error (e.g., exit code 1), the deregister_runner function in entrypoint.sh is never called. This leaves orphaned runner instances in github. Closes #581.

The current trap code only looks for external signals to kill/stop the runner process, but not when the runner process exits by itself. By also trapping EXIT, we can ensure deregister_runner is called whenever the runner exits.

Changes

• entrypoint.sh: Added EXIT to the trap_with_arg list so the script guarantees deregistration regardless of how the container's main process terminates.
• goss_trap_exit.yaml: Added a new test to validate if exit code 1 is received, that deregister happens correctly.
• .github/workflows/test.yml: Integrated the new test into the CI pipeline for both Ubuntu and Debian builds.

Testing

Locally ran the new test without the change to trap and verified it failed. Re-ran the test with the change and verified it passes. Also ran goss_full.yaml and goss_reusage_fail to ensure the change didn't break existing tests.

[myoung34]

The new test looks like theres a race condition to pass

[jonathan528i]

The new test looks like theres a race condition to pass

My best guess is due to the exit call in deregister_runner function. I'm not sure if the exit call in different bash environments will either return the error code that triggered the trap, or the last executed command before the exit call in the function (which would be 0, therefore causing the test to fail since it's expecting 1)?

I've updated the code but we'll have to see if that fixes the tests once the pipeline runs again.

[myoung34]

Seems to always fail for arm64

[myoung34]

My concern is how flakey these tests are; arm64 fails consistently

[myoung34]

the issue here is 2 things:

• that EXIT doesnt trap signals
• qemu is doing something differently with how EXIT works here (why arm64 only, cant confirm what though)

Suggested change

	COMMAND_EXIT_CODE=$?
	local COMMAND_EXIT_CODE="${1:-EXIT}"
	echo "Caught ${COMMAND_EXIT_CODE} - Deregistering runner"