Complete TypeScript migration: Add strict types, build system, and GitHub Pages deployment

- Migrated all code to TypeScript with strict type checking
- Reorganized structure: src/core/ and src/web/
- Added comprehensive type definitions in src/core/types.ts
- Updated build system to output dist/script.js
- Fixed CLI tool (removed duplicate shebang)
- Updated GitHub Actions workflow for Pages deployment
- All tests passing: typecheck, build, CLI working
- Web app ready for deployment

Author: mytherapy-coding

.github/workflows/pages.yml

@@ -0,0 +1,54 @@
+name: Build and Deploy to GitHub Pages
+
+on:
+  push:
+    branches: ["main"]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+concurrency:
+  group: "pages"
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+
+      - name: Install
+        run: npm ci
+
+      - name: Typecheck
+        run: npm run typecheck
+
+      - name: Build
+        run: npm run build
+
+      - name: Configure Pages
+        uses: actions/configure-pages@v5
+
+      - name: Upload artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: dist
+
+  deploy:
+    runs-on: ubuntu-latest
+    needs: build
+    environment:
+      name: github-pages
+    steps:
+      - name: Deploy
+        uses: actions/deploy-pages@v4

TESTING.md

@@ -0,0 +1,128 @@
+# Testing Guide
+
+## Quick Test Commands
+
+### 1. Type Check
+```bash
+npm run typecheck
+```
+Should show: **0 errors**
+
+### 2. Build
+```bash
+npm run build
+```
+Should create `dist/` folder with:
+- `dist/index.html`
+- `dist/script.js`
+- `dist/style.css`
+- `dist/data/` (word lists)
+- `dist/cli/index.js`
+
+### 3. Test CLI Tool
+
+#### Basic password:
+```bash
+./dist/cli/index.js pwd --len 16
+```
+
+#### Passphrase:
+```bash
+./dist/cli/index.js passphrase --words 6
+```
+
+#### User IDs:
+```bash
+./dist/cli/index.js userid --mode cvc --count 5
+```
+
+#### JSON output:
+```bash
+./dist/cli/index.js pwd --len 20 --json
+```
+
+#### iCloud passwords:
+```bash
+./dist/cli/index.js icloud --count 3
+```
+
+### 4. Test Web App Locally
+
+#### Option A: Using serve (recommended)
+```bash
+npm run serve:dist
+```
+Then open: `http://localhost:3000` (or the URL shown)
+
+#### Option B: Using the custom server
+```bash
+npm start
+```
+Then open: `http://localhost:8000`
+
+## What to Test in the Web App
+
+### Password Tab:
+- [ ] Generate strong password (default mode)
+- [ ] Change length and regenerate
+- [ ] Toggle character types (lowercase, uppercase, digits, symbols)
+- [ ] Custom symbols input
+- [ ] iCloud mode generates password
+- [ ] Easy to write mode
+- [ ] Easy to say mode
+- [ ] Passphrase (Diceware) mode
+- [ ] Entropy and crack time display updates
+- [ ] Change hardware profile and see crack time update
+- [ ] Copy button works
+- [ ] Share button generates URL
+- [ ] Clear button resets everything
+
+### User ID Tab:
+- [ ] Switch to User ID tab
+- [ ] Generate CVC user IDs
+- [ ] Generate Words user IDs
+- [ ] Change settings (syllables, words count, separator)
+- [ ] Copy individual user IDs
+- [ ] Share button generates URL
+- [ ] Reset settings button works
+
+### Share Links:
+- [ ] Copy share link from Password tab
+- [ ] Open in new tab/window
+- [ ] Settings restore correctly
+- [ ] Password auto-generates (if `auto=1` in URL)
+- [ ] Copy share link from User ID tab
+- [ ] Settings restore correctly
+- [ ] User IDs auto-generate (if `auto=1` in URL)
+
+### Persistence:
+- [ ] Change settings
+- [ ] Refresh page
+- [ ] Settings are restored
+- [ ] Active tab is restored
+
+## Expected Results
+
+✅ **Type check**: 0 errors
+✅ **Build**: Creates complete `dist/` folder
+✅ **CLI**: All commands work and produce output
+✅ **Web app**: Loads, generates passwords/IDs, shows entropy, copy/share work
+✅ **Share links**: Restore settings and auto-generate
+✅ **Persistence**: Settings saved and restored on reload
+
+## Troubleshooting
+
+### CLI not working?
+- Make sure you ran `npm install` and `npm run build`
+- Check file is executable: `ls -l dist/cli/index.js`
+- Try: `node dist/cli/index.js pwd --len 16`
+
+### Web app not loading?
+- Make sure you built: `npm run build`
+- Check `dist/` folder exists with files
+- Use a local server (not `file://`)
+- Check browser console for errors
+
+### Type errors?
+- Run `npm run typecheck` to see all errors
+- Make sure all TypeScript files are in `src/`

build.mjs

@@ -19,11 +19,11 @@ async function buildWeb() {
   console.log("Building web app...");
 
   await build({
-    entryPoints: ["js/init.ts"],
+    entryPoints: ["src/web/main.ts"],
     bundle: true,
-    outdir: "dist",
+    outfile: "dist/script.js",
     format: "esm",
-    target: "es2022",
+    target: "es2020",
     platform: "browser",
     sourcemap: !isProduction,
     minify: isProduction,
@@ -32,15 +32,25 @@ async function buildWeb() {
     }
   });
 
-  // Copy and update HTML - change script reference to bundled JS
+  // Copy and update HTML - change script reference to script.js and CSS to style.css
   if (!existsSync("dist")) mkdirSync("dist", { recursive: true });
-  const htmlContent = readFileSync("index.html", "utf8");
-  const updatedHtml = htmlContent.replace(
-    /<script type="module" src="\.\/js\/init\.js"><\/script>/,
-    '<script type="module" src="./init.js"></script>'
+  let htmlContent = readFileSync("index.html", "utf8");
+  htmlContent = htmlContent.replace(
+    /<script type="module" src="[^"]*"><\/script>/,
+    '<script type="module" src="./script.js"></script>'
+  );
+  htmlContent = htmlContent.replace(
+    /href="\.\/styles\.css"/,
+    'href="./style.css"'
   );
-  writeFileSync("dist/index.html", updatedHtml);
-  copyFileSync("styles.css", "dist/styles.css");
+  writeFileSync("dist/index.html", htmlContent);
+  
+  // Copy style.css (note: keeping styles.css name for now, but copying as style.css per requirements)
+  if (existsSync("styles.css")) {
+    copyFileSync("styles.css", "dist/style.css");
+  } else if (existsSync("style.css")) {
+    copyFileSync("style.css", "dist/style.css");
+  }
 
   // Copy data files
   if (!existsSync("dist/data")) mkdirSync("dist/data", { recursive: true });
@@ -62,7 +72,7 @@ async function buildCLI() {
   await build({
     entryPoints: ["cli/index.ts"],
     bundle: true,
-    outdir: "dist/cli",
+    outfile: "dist/cli/index.js",
     format: "esm",
     target: "node18",
     platform: "node",
@@ -73,6 +83,10 @@ async function buildCLI() {
     }
   });
 
+  // Make CLI executable
+  const { chmodSync } = await import("fs");
+  chmodSync("dist/cli/index.js", 0o755);
+  
   console.log("CLI built successfully!");
 }
 
@@ -82,9 +96,9 @@ async function buildCore() {
   // Core is used by both web and CLI, so we build it separately
   // Web will bundle it, CLI will use it directly
   await build({
-    entryPoints: ["core/index.ts"],
+    entryPoints: ["src/core/index.ts"],
     bundle: false,
-    outdir: "dist/core",
+    outdir: "dist/src/core",
     format: "esm",
     target: "es2022",
     platform: "neutral",
@@ -117,9 +131,10 @@ async function main() {
     console.log("\n✅ Build complete!");
     console.log("📦 Output: dist/");
     console.log("   - dist/index.html (web app)");
-    console.log("   - dist/init.js (bundled web JS)");
+    console.log("   - dist/script.js (bundled web JS)");
+    console.log("   - dist/style.css");
+    console.log("   - dist/data/ (word lists)");
     console.log("   - dist/cli/index.js (CLI executable)");
-    console.log("   - dist/core/ (core library)");
 
   } catch (error) {
     console.error("Build failed:", error);

cli/index.ts

@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 import fs from "node:fs";
 import { parseArgs, type ParsedArgs } from "./parseArgs.js";
 import { formatText, formatJSON } from "./output.js";
@@ -17,8 +15,8 @@ import {
   calculateEntropyBits,
   estimateCrackTimeSeconds,
   CRACK_HARDWARE_PROFILES
-} from "../core/index.js";
-import type { PasswordResult } from "../core/types.js";
+} from "../src/core/index.js";
+import type { PasswordResult } from "../src/core/types.js";
 
 // Load word lists
 const dicewareWords: string[] = JSON.parse(

cli/output.ts

@@ -1,5 +1,5 @@
-import { formatCrackTime, CRACK_HARDWARE_PROFILES } from "../core/index.js";
-import type { PasswordResult } from "../core/types.js";
+import { formatCrackTime, CRACK_HARDWARE_PROFILES } from "../src/core/index.js";
+import type { PasswordResult } from "../src/core/types.js";
 
 interface ResultWithValue {
   value: string;

cli/random.ts

@@ -1,6 +1,6 @@
 // cli/random.ts
 import { randomInt as nodeRandomInt } from "node:crypto";
-import type { RandomIntFunction } from "../core/types.js";
+import type { RandomIntFunction } from "../src/core/types.js";
 
 export function randomInt(max: number): number {
   return nodeRandomInt(max);

core/types.ts

@@ -231,6 +231,6 @@ <h2>User ID Generator</h2>
 
   </div>
 
-  <script type="module" src="./js/init.js"></script>
+  <script type="module" src="./script.js"></script>
 </body>
 </html>