Implement in-GUI sort and filter controls for shop search results#108
Open
myzticbean wants to merge 4 commits into
Open
Implement in-GUI sort and filter controls for shop search results#108myzticbean wants to merge 4 commits into
myzticbean wants to merge 4 commits into
Conversation
- Add SortMode enum (DEFAULT, PRICE_ASC, PRICE_DESC, DISTANCE_ASC) with next() cycle - Add PlayerSortFilterPrefs model (sort mode + 3 filter toggles, Gson-serializable) - Add PlayerPrefsStorageUtil: ConcurrentHashMap-backed, async saves via VirtualThreadScheduler, persists to player_prefs.json on disable - Hook load/save into FindItemAddOn lifecycle (runPluginStartupTasks / onDisable) - Free nav bar slots 47/48/50/51 in PaginatedMenu (previously idle fillers) - FoundShopsMenu: lazy applyPrefs() stream applies filters+sort only at render time, raw result list never modified; setSortFilterButtons() populates slots 47/48/50/51 with HOPPER sort button and LIME/GRAY_DYE filter toggles; click handlers cycle sort mode and toggle each filter with page reset and async prefs save
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
player_prefs.json(Gson, async saves)New files
models/enums/SortMode.javamodels/PlayerSortFilterPrefs.javautils/json/PlayerPrefsStorageUtil.javaModified files
FindItemAddOn.java— lifecycle hooks (load on startup, sync save on disable)PaginatedMenu.java— freed nav bar slots 47/48/50/51 (previously idle fillers)FoundShopsMenu.java—applyPrefs(),setSortFilterButtons(), updatedsetMenuItems(), 4 new click handler casesTest plan
/finditem TO_SELL diamond— 4 new buttons visible in nav bar