feat: Do not print the secret key#87
Open
flub wants to merge 1 commit into
Open
Conversation
It is scary when folks have to worry about secrets being printed. #84 will solve the key persistence in a much better way anyway.
Contributor
Author
|
I don't get the lint failure. My local rustfmt insists it is like this, the one on CI insists that. But both are stable rust? |
Contributor
|
this needs to be an option, if you want to reuse the key it needs to be printed so you can set it using the env variable |
Contributor
I think it would be better to have a separate dumbpipe command to generate and print the secret, which can then be reused for subsequent dumbpipe commands. In git-annex-p2p-iroh (https://git-annex.branchable.com/special_remotes/p2p/git-annex-p2p-iroh) the secret is generated with gpg because there is no easily parsable way to get it out of dumbpipe yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is scary when folks have to worry about secrets being printed. #84
will solve the key persistence in a much better way anyway.