Skip to content

sync: short-hex Debug for peer from#98

Merged
dignifiedquire merged 1 commit into
n0-computer:mainfrom
cbenhagen:sync-peer-debug-short-hex
May 8, 2026
Merged

sync: short-hex Debug for peer from#98
dignifiedquire merged 1 commit into
n0-computer:mainfrom
cbenhagen:sync-peer-debug-short-hex

Conversation

@cbenhagen
Copy link
Copy Markdown
Contributor

Description

Remote peer identity in Debug for InsertOrigin::Sync and Event::RemoteInsert was printed as a [u8; 32] integer list, unlike other logs that use compact hex. This switches those fields to derive_more::Debug with hex::encode of the first 5 bytes, matching iroh_base::PublicKey::fmt_short() / EndpointId logging style.

Also updates the PeerIdBytes doc line to refer to EndpointId, and refreshes the TODO to suggest iroh::EndpointId (re-exported from iroh-base) instead of outdated PeerId / iroh-net wording.

Breaking Changes

None.

Notes & open questions

Using iroh::EndpointId instead of PeerIdBytes ([u8; 32]) would be a breaking public API change but give us stronger typing, validation and built-in helpers (fmt_short, etc.). Happy to open a follow-up PR with that.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@n0bot n0bot Bot added this to iroh May 6, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh May 6, 2026
Copy link
Copy Markdown
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dignifiedquire dignifiedquire merged commit 1f88013 into n0-computer:main May 8, 2026
24 of 25 checks passed
@github-project-automation github-project-automation Bot moved this from 🚑 Needs Triage to ✅ Done in iroh May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants