chore(ci): make sccache fail gracefully#4208
Merged
dignifiedquire merged 5 commits intomainfrom Apr 30, 2026
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4208/docs/iroh/ Last updated: 2026-04-29T12:57:45Z |
| done | ||
| echo "::warning::sccache backend unreachable; running this job without sccache" | ||
| # mozilla-actions/sccache-action exports these via $GITHUB_ENV — override. | ||
| echo "RUSTC_WRAPPER=" >> "$GITHUB_ENV" |
Contributor
There was a problem hiding this comment.
is this the right way to clear an env variable? :O
Collaborator
Author
There was a problem hiding this comment.
well 2 things happening here:
a) if it was set before you kinda need to unset it so this would be bash wise wrong
b) this is github actions and they have their funny github_env thing which I'd rather not touch more than needed and it doesn't have proper unset semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wraps the sccache config into a check so if infra fails for some reason it retries and if that fails too it moves on to complete the job without it.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme