fix(iroh-dns-server): DNS write benchmark measurement#4382
Merged
Conversation
Measure only the DNS write loop in the Criterion benchmark. The old benchmark used `b.iter`, so Criterion measured runtime creation, config loading, server binding, client setup, packet creation, the publish loop, and shutdown. It also republished the same signed packet for every iteration. This patch moves setup outside the measured duration, switches to `iter_custom`, and generates distinct signed packets for the measured publish batch. This makes `dns_server_writes` report write-path throughput instead of setup-heavy duplicate-publish timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measure only the DNS write loop in the Criterion benchmark.
The old benchmark used
b.iter, so Criterion measured runtime creation, config loading, server binding, client setup, packet creation, the publish loop, and shutdown. It also republished the same signed packet for every iteration.This patch moves setup outside the measured duration, switches to
iter_custom, and generates distinct signed packets for the measured publish batch. This makesdns_server_writesreport write-path throughput instead of setup-heavy duplicate-publish timing.Per-element view:
Change checklist
proposed change and wrote an as clear and concise description as
they could.
intended effect.