feat!: Use portable atomic so we can run on esp32#107
Open
rklaehn wants to merge 7 commits into
Open
Conversation
Use iroh without default features so we don't inherit ring
Frando
reviewed
Jul 1, 2026
| # default-features = false drops irpc's `noq_endpoint_setup` (rcgen + noq/rustls-ring, | ||
| # both ring) — test-only cert utilities not needed by the iroh transport. Keep the | ||
| # real RPC features. Required for the ring-free Xtensa ESP32 build. | ||
| irpc = { version = "0.17.0", path = "..", default-features = false, features = ["rpc", "spans", "stream", "derive"] } |
Member
There was a problem hiding this comment.
Maybe spans should be defined as a feature on irpc-iroh and passed through to irpc Same for tracing-opentelemetry I think.
Also let's reword the LLM comment here IMO.
Collaborator
Author
There was a problem hiding this comment.
I don't think we need any comment. We should make it the default to include iroh with no default features for all library crates.
Member
There was a problem hiding this comment.
But should we unconditionally enable the spans feature for iprc? Or should that be gated on a spans feature in irpc-iroh (on by default) that forwards it to irpc? I think yes.
Importing a crate with default features false should be the default, it does not need a comment.
dignifiedquire
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use portable atomic so we can run on esp32
Also don't use iroh without default features so we don't inherit ring. None of these changes should be a problem for the normal desktop platforms.