fix(netwatch): various small improvments#103
Merged
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/103/docs/net_tools/ Last updated: 2026-02-26T12:19:29Z |
flub
reviewed
Feb 26, 2026
Contributor
flub
left a comment
There was a problem hiding this comment.
generally looks good i think. glad to see the 250ms wakeup interval being gone. one nit/question more.
matheus23
approved these changes
Feb 26, 2026
matheus23
reviewed
Feb 26, 2026
cf8274a to
6504ae0
Compare
matheus23
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2487d66: Theparse_ribloop failed to advance the buffer pointer when encountering a message with a mismatched routing stack version, causing an infinite loop.8785aa1:Iterator::zipsilently stopped at the shorter iterator, so an interface gaining or losing addresses was not detected as a change.da51515: The comparison only iterated the old state's interfaces, so a newly appeared interface was never reported as a major change.10eb2c8: TheOption<bool>pending state allowed a normal network event to overwrite a pending time-jump signal before it was processed.f3986e3:Interval::reset_immediately()caused the debounce timer to fire on the next poll, defeating burst coalescing. A one-shotSleepthat extends its deadline on each event now provides a true quiet-period debounce.68a334f: The unregister methods removed theArc<Callback>from the map before callingCancelMibChangeNotify2, creating a window where Windows could invoke a callback through a dangling pointer.