fix(netwatch): compilation for all Apple targets#152
Closed
yukibtc wants to merge 1 commit into
Closed
Conversation
Fix `netwatch` cfg gates so the Darwin/BSD implementation is enabled for all Apple targets via `target_vendor = "apple"`, instead of only `macos` and `ios`. This covers Apple targets such as watchOS, tvOS, and visionOS at compile time by applying the same Apple routing implementation and target-specific dependencies consistently. Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
Contributor
|
did you confirm these all work the same? the reason these are currently not enabled is that we have no testing for these platforms |
Author
|
Sorry, I assumed these platforms worked the same way, but after digging deeper I found that this is not the case. Some of them, such as watchOS, don't provide access to the BSD/route sockets API. I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
netwatchcfg gates so the Darwin/BSD implementation is enabled for all Apple targets viatarget_vendor = "apple", instead of onlymacosandios.This covers Apple targets such as watchOS, tvOS, and visionOS at compile time by applying the same Apple routing implementation and target-specific dependencies consistently.
Change checklist