feat(netwatch): adjust for quinn api changes#26
Merged
Conversation
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/26/docs/net_tools/ Last updated: 2025-06-03T08:26:45Z |
matheus23
reviewed
May 27, 2025
Member
There was a problem hiding this comment.
Sorry for the whole confusion here.
It might be helpful to move this file to interfaces/native.rs so it lives on the same level as wasm_browser.rs.
The hope would be this makes it a lot clearer that they implement the same stuff.
matheus23
approved these changes
May 30, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
I'm happy with moving on with this, even if I'm not super confident in the waker stuff.
It's fair to say it's roughly as good as the status quo.
github-merge-queue Bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Jun 11, 2025
A first step towards the work of #3276 ## Breaking changes - `iroh::watcher` is now its own crate `n0-watcher` - `iroh::endpoint::Endpoint::node_addr` now returns `impl Watcher<Value = Option<NodeAddr>>` - `iroh::endpoint::Endpoint::home_relay` now returns `impl Watcher<Value = Vec<RelayUrl>>` - `iroh::endpoint::Endpoint::bound_sockets` now returns `Vec<SocketAddr>` - `iroh-quinn` is updated to `0.14.0` Depends on - [x] n0-computer/n0-watcher#1 - [x] n0-computer/net-tools#26 - [x] n0-computer/noq#67 - [x] n0-computer/n0-watcher#3 --------- Co-authored-by: Franz Heinzmann <frando@unbiskant.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.