feat!: edition2024, MSRV 1.85 and update deps to latest#30
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/30/docs/net_tools/ Last updated: 2025-07-14T10:05:42Z |
dignifiedquire
changed the title
rklaehn
left a comment
rklaehn
left a comment
There was a problem hiding this comment.
Seems fine. Mostly changes forced by clippy and the rand stuff.
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Not sure how bad the impact of a double socket2 dependency is, but generally this looks good 👍
| "libc", | ||
| "pin-project-lite", | ||
| "socket2", | ||
| "socket2 0.5.10", |
There was a problem hiding this comment.
Seems like tokio, hyper and a bunch of other libs aren't on socket2 version 0.6 yet.
Should we perhaps not upgrade that dependency yet, so we don't duplicate?
There was a problem hiding this comment.
I think this is fine for now, socket2@0.6 is quite new, and the duplication will reduce once those deps update
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
The editions are still left to 2021? Unless you meant rustfmt edition 2024, in which case we should also configure a style_edition = "2024" in rustffmt.toml (https://doc.rust-lang.org/edition-guide/rust-2024/rustfmt-style-edition.html)?
fixed |
## Description Updates dependencies where possible. Closes #3385 Depends on - [x] n0-computer/net-tools#30 ## Breaking Changes All crates are now `edition2024`
4 participants
Description
Updates all dependencies to their latest versions
Breaking Changes
Notes & open questions
Change checklist