refactor(proto): Raise limit of path responses kept around per PathData#622
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/622/docs/noq/ Last updated: 2026-04-29T13:59:55Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5787.0 Mbps | 7960.0 Mbps | -27.3% | 98.2% / 99.3% |
| medium-concurrent | 5448.6 Mbps | 7756.6 Mbps | -29.8% | 96.5% / 98.2% |
| medium-single | 3631.6 Mbps | 4749.1 Mbps | -23.5% | 96.8% / 98.7% |
| small-concurrent | 3915.9 Mbps | 5337.1 Mbps | -26.6% | 97.1% / 99.6% |
| small-single | 3581.7 Mbps | 4914.0 Mbps | -27.1% | 96.3% / 98.7% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3172.1 Mbps | 4024.8 Mbps | -21.2% |
| lan | 782.5 Mbps | 810.3 Mbps | -3.4% |
| lossy | 69.8 Mbps | 55.9 Mbps | +25.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 25.8% slower on average
flub
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MAX_PATH_RESPONSESfrom 16 to 32.16 is not enough with users potentially having 25 interfaces or more configured. Now that we send off-path PATH_CHALLENGEs all from a single
PathId, we need to be able to keep around 32 PATH_RESPONSEs queued for sending for potentially that many challenges.I've considered other values for this such as 64 or 128, but the worst-case memory use caused by malicious attackers is quite bad, so I've opted for the lowest reasonable value.
MAX_QNT_ADDRSin the proptests from 12 to 32, to match values that will be set in iroh: feat(iroh)!: update QNT config defaults & update to latest noq main iroh#4213Closes #613 (together with n0-computer/iroh#4213).
Change checklist