Conversation
Frando
marked this pull request as ready for review
March 9, 2026 15:08
dignifiedquire
approved these changes
Mar 9, 2026
Add Identifier::Ip variant with auto-detection via Identifier::from_str.
ACME orders now correctly use {"type":"ip"} for IP address identifiers.
Frando
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for IP certificates, as specified in RFC 8738.
The change is straightforward, we just need to request the correct type in the certificate order. Everything else doesn't need any changes.
Breaking changes
This is a breaking change because the public enum
acme::Identifiergained a new variant.This is unfortunate, because this does not actually have to be public. We should do a cleanup pass to make more things non-public to reduce public API surface.