From bf78b9b80cbbf8578dabf6dec63e3f0fbabd52e9 Mon Sep 17 00:00:00 2001 From: gabrielslach Date: Thu, 7 May 2020 13:51:49 +0800 Subject: [PATCH 1/2] explicitly set the the useNativeDriver to false Get rid of the warning indicating the must to specify the not use of native driver --- src/components/field/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/field/index.js b/src/components/field/index.js index 281b7451..b6e6edfd 100644 --- a/src/components/field/index.js +++ b/src/components/field/index.js @@ -223,6 +223,7 @@ export default class TextField extends PureComponent { let options = { toValue: this.focusState(), + useNativeDriver: false, duration, }; From ab55f941165e5a0add8a594511df8c1eba634d3a Mon Sep 17 00:00:00 2001 From: gabrielslach Date: Thu, 7 May 2020 14:39:40 +0800 Subject: [PATCH 2/2] Fixed issue with proptypes deprecations react --- changelog.md | 4 --- src/components/affix/index.js | 2 -- .../field-filled/__snapshots__/test.js.snap | 12 ++++----- .../field-outlined/__snapshots__/test.js.snap | 12 ++++----- .../field/__snapshots__/test.js.snap | 26 +++++++++---------- src/components/field/index.js | 4 +-- src/components/field/styles.js | 1 + src/components/helper/index.js | 2 -- src/components/label/index.js | 1 - 9 files changed, 27 insertions(+), 37 deletions(-) diff --git a/changelog.md b/changelog.md index 5c73bbc2..9c94d7c0 100644 --- a/changelog.md +++ b/changelog.md @@ -7,10 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -### Added - -- `bottom` key for `contentInset` prop - ## [0.16.0] - 2019-10-24 ### Added diff --git a/src/components/affix/index.js b/src/components/affix/index.js index 0f85022e..08f97a8e 100644 --- a/src/components/affix/index.js +++ b/src/components/affix/index.js @@ -11,8 +11,6 @@ export default class Affix extends PureComponent { static propTypes = { numberOfLines: PropTypes.number, - style: Animated.Text.propTypes.style, - color: PropTypes.string.isRequired, fontSize: PropTypes.number.isRequired, diff --git a/src/components/field-filled/__snapshots__/test.js.snap b/src/components/field-filled/__snapshots__/test.js.snap index 485b017f..b55ee33b 100644 --- a/src/components/field-filled/__snapshots__/test.js.snap +++ b/src/components/field-filled/__snapshots__/test.js.snap @@ -150,9 +150,9 @@ exports[`renders 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -313,9 +313,9 @@ exports[`renders accessory 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -475,9 +475,9 @@ exports[`renders counter 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -660,9 +660,9 @@ exports[`renders disabled value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -822,9 +822,9 @@ exports[`renders title 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -1001,9 +1001,9 @@ exports[`renders value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, diff --git a/src/components/field-outlined/__snapshots__/test.js.snap b/src/components/field-outlined/__snapshots__/test.js.snap index 011e0330..df4605b0 100644 --- a/src/components/field-outlined/__snapshots__/test.js.snap +++ b/src/components/field-outlined/__snapshots__/test.js.snap @@ -270,9 +270,9 @@ exports[`renders 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -553,9 +553,9 @@ exports[`renders accessory 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -835,9 +835,9 @@ exports[`renders counter 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -1136,9 +1136,9 @@ exports[`renders disabled value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -1418,9 +1418,9 @@ exports[`renders title 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, @@ -1717,9 +1717,9 @@ exports[`renders value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 12, "paddingRight": 12, }, diff --git a/src/components/field/__snapshots__/test.js.snap b/src/components/field/__snapshots__/test.js.snap index 705e7bf3..2f89f6ff 100644 --- a/src/components/field/__snapshots__/test.js.snap +++ b/src/components/field/__snapshots__/test.js.snap @@ -147,9 +147,9 @@ exports[`renders 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -306,9 +306,9 @@ exports[`renders counter 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -488,9 +488,9 @@ exports[`renders default value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -647,9 +647,9 @@ exports[`renders disabled value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -806,9 +806,9 @@ exports[`renders error 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -983,9 +983,9 @@ exports[`renders left accessory 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -1148,9 +1148,9 @@ exports[`renders multiline value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -1332,9 +1332,9 @@ exports[`renders prefix 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -1491,9 +1491,9 @@ exports[`renders restriction 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -1674,9 +1674,9 @@ exports[`renders right accessory 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -1858,9 +1858,9 @@ exports[`renders suffix 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -2017,9 +2017,9 @@ exports[`renders title 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, @@ -2193,9 +2193,9 @@ exports[`renders value 1`] = ` "alignItems": "flex-start", "flexDirection": "row", "justifyContent": "flex-end", + "minHeight": 8, }, Object { - "minHeight": 8, "paddingLeft": 0, "paddingRight": 0, }, diff --git a/src/components/field/index.js b/src/components/field/index.js index b6e6edfd..fd69a17b 100644 --- a/src/components/field/index.js +++ b/src/components/field/index.js @@ -79,7 +79,6 @@ export default class TextField extends PureComponent { input: PropTypes.number, left: PropTypes.number, right: PropTypes.number, - bottom: PropTypes.number, }), labelOffset: Label.propTypes.offset, @@ -129,7 +128,6 @@ export default class TextField extends PureComponent { input: 8, left: 0, right: 0, - bottom: 8, }; static labelOffset = { @@ -225,6 +223,7 @@ export default class TextField extends PureComponent { toValue: this.focusState(), useNativeDriver: false, duration, + }; startAnimation(focusAnimation, options, this.onFocusAnimationEnd); @@ -573,7 +572,6 @@ export default class TextField extends PureComponent { let containerStyle = { paddingLeft: contentInset.left, paddingRight: contentInset.right, - minHeight: contentInset.bottom, }; let styleProps = { diff --git a/src/components/field/styles.js b/src/components/field/styles.js index 012a6e14..e696d2a6 100644 --- a/src/components/field/styles.js +++ b/src/components/field/styles.js @@ -22,6 +22,7 @@ export default StyleSheet.create({ }, helperContainer: { + minHeight: 8, flexDirection: 'row', justifyContent: 'flex-end', alignItems: 'flex-start', diff --git a/src/components/helper/index.js b/src/components/helper/index.js index 6060f9f5..c1ae90dd 100644 --- a/src/components/helper/index.js +++ b/src/components/helper/index.js @@ -11,8 +11,6 @@ export default class Helper extends PureComponent { disabled: PropTypes.bool, - style: Animated.Text.propTypes.style, - baseColor: PropTypes.string, errorColor: PropTypes.string, diff --git a/src/components/label/index.js b/src/components/label/index.js index 82eaf033..ff1809cb 100644 --- a/src/components/label/index.js +++ b/src/components/label/index.js @@ -43,7 +43,6 @@ export default class Label extends PureComponent { y1: PropTypes.number, }), - style: Animated.Text.propTypes.style, label: PropTypes.string, };