Skip to content

Support PRs: Multiple-mixed prs#4647

Merged
HumanistSerif merged 3 commits into
mainfrom
support-prs
May 19, 2026
Merged

Support PRs: Multiple-mixed prs#4647
HumanistSerif merged 3 commits into
mainfrom
support-prs

Conversation

@luendres
Copy link
Copy Markdown
Contributor

@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit f2419b9
🔍 Latest deploy log https://app.netlify.com/projects/n8n-docs/deploys/6a0c25aa526bda000853ed82
😎 Deploy Preview https://deploy-preview-4647--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Architecture diagram
sequenceDiagram
    participant Admin as Admin
    participant Docs as Documentation
    participant Config as Environment Config
    participant Runner as Task Runner
    participant S3 as S3 Storage
    participant Azure as Azure AD / Entra ID

    Note over Admin,Azure: PR touches three independent documentation areas

    Note over Admin,Docs: Task Runner Timeout Correction
    Admin->>Docs: Read N8N_RUNNERS_TASK_REQUEST_TIMEOUT default
    Config->>Runner: Set N8N_RUNNERS_TASK_REQUEST_TIMEOUT=60
    Runner->>Runner: Wait up to 60s for available runner
    alt Runner available within 60s
        Runner-->>Runner: Execute task
    else Timeout (60s)
        Runner->>Runner: Terminate task request
    end

    Note over Admin,S3: S3 Region Validation & Upgrade Flow
    Admin->>S3: Configure N8N_EXTERNAL_STORAGE_S3_BUCKET_REGION
    S3->>S3: Validate region format (alphanumeric + hyphens only)
    alt Valid region (e.g., us-east-1)
        S3->>S3: Connect successfully
    else Invalid region (contains underscore or special char)
        S3->>S3: Connection failure on startup
        Admin->>Docs: Consult upgrade guidelines
    end
    Admin->>S3: Upgrade all n8n components to same version
    Admin->>S3: Set N8N_EXTERNAL_STORAGE_S3_PROTOCOL=http (if needed)
    Admin->>S3: Use N8N_EXTERNAL_STORAGE_S3_ACCESS_KEY

    Note over Admin,Azure: App Roles for Multiple Projects
    Admin->>Azure: Define App Roles in App Registration (e.g., proj1:editor)
    Azure->>Azure: Save updated App Manifest
    Admin->>Azure: Assign users/groups to App Roles in Enterprise App
    Azure->>Azure: Configure SAML claim 'n8n_projects' from user.assignedroles
    Azure-->>Admin: Emit all assigned roles as array in SAML response
    Admin->>Admin: n8n receives complete project-role assignments
    alt Multiple projects assigned
        Admin->>Admin: Access multiple projects correctly
    else Single project (old group-based claim behavior)
        Admin->>Admin: Only first matching group applied
    end
Loading

Re-trigger cubic

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 15, 2026

Deploying n8n-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2419b9
Status:⚡️  Build in progress...

View logs

Co-authored-by: Copilot <copilot@github.com>
@github-actions
Copy link
Copy Markdown

No description provided.

@HumanistSerif HumanistSerif merged commit 58b5409 into main May 19, 2026
4 of 5 checks passed
@HumanistSerif HumanistSerif deleted the support-prs branch May 19, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants