Support PRs: Multiple-mixed prs#4647
Merged
Merged
Conversation
Contributor
luendres
commented
May 15, 2026
- Fixed wrong default value for N8N_RUNNERS_TASK_REQUEST_TIMEOUT: It was 20, but we can see [here] that the correct one is 60. (https://github.com/n8n-io/n8n/blob/46739a5bc464af81ebf5145d2ae37fd3bfbb5fa8/packages/%40n8n/config/src/configs/runners.config.ts#L61)
- S3 Binary Data storage region validation and upgrade compatibility.
- Assigning multiple projects with their respective roles using App roles instead of group-based claims.
✅ Deploy Preview for n8n-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Architecture diagram
sequenceDiagram
participant Admin as Admin
participant Docs as Documentation
participant Config as Environment Config
participant Runner as Task Runner
participant S3 as S3 Storage
participant Azure as Azure AD / Entra ID
Note over Admin,Azure: PR touches three independent documentation areas
Note over Admin,Docs: Task Runner Timeout Correction
Admin->>Docs: Read N8N_RUNNERS_TASK_REQUEST_TIMEOUT default
Config->>Runner: Set N8N_RUNNERS_TASK_REQUEST_TIMEOUT=60
Runner->>Runner: Wait up to 60s for available runner
alt Runner available within 60s
Runner-->>Runner: Execute task
else Timeout (60s)
Runner->>Runner: Terminate task request
end
Note over Admin,S3: S3 Region Validation & Upgrade Flow
Admin->>S3: Configure N8N_EXTERNAL_STORAGE_S3_BUCKET_REGION
S3->>S3: Validate region format (alphanumeric + hyphens only)
alt Valid region (e.g., us-east-1)
S3->>S3: Connect successfully
else Invalid region (contains underscore or special char)
S3->>S3: Connection failure on startup
Admin->>Docs: Consult upgrade guidelines
end
Admin->>S3: Upgrade all n8n components to same version
Admin->>S3: Set N8N_EXTERNAL_STORAGE_S3_PROTOCOL=http (if needed)
Admin->>S3: Use N8N_EXTERNAL_STORAGE_S3_ACCESS_KEY
Note over Admin,Azure: App Roles for Multiple Projects
Admin->>Azure: Define App Roles in App Registration (e.g., proj1:editor)
Azure->>Azure: Save updated App Manifest
Admin->>Azure: Assign users/groups to App Roles in Enterprise App
Azure->>Azure: Configure SAML claim 'n8n_projects' from user.assignedroles
Azure-->>Admin: Emit all assigned roles as array in SAML response
Admin->>Admin: n8n receives complete project-role assignments
alt Multiple projects assigned
Admin->>Admin: Access multiple projects correctly
else Single project (old group-based claim behavior)
Admin->>Admin: Only first matching group applied
end
Co-authored-by: Copilot <copilot@github.com>
HumanistSerif
approved these changes
May 19, 2026
|
No description provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.