Skip to content

Commit 53f8fe2

Browse files
author
Andrea Cosentino
committed
fix: internal resolution logic
1 parent 83d26c1 commit 53f8fe2

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/utils/plugin.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,7 @@ export const runPlugin = async (req: IncomingMessage, response: ServerResponse,
670670
break;
671671
case "MANUALLY_HANDLED":
672672
dataResponse.data = `${error.message} Handled request did not send any response`;
673+
dataResponse.errorMiddlewares = undefined;
673674
break;
674675
case "ERROR":
675676
dataResponse.status = error.getCode();
@@ -996,7 +997,11 @@ export const runWsPlugin = (server: ViteDevServer | PreviewServer, logger: ILogg
996997
if (!connection.closed) {
997998
connection.markClosed();
998999
if (currentHandler.onClose) {
999-
await currentHandler.onClose(connection, code, reason.toString() || "", true);
1000+
try {
1001+
await currentHandler.onClose(connection, code, reason.toString() || "", true);
1002+
} catch (err: any) {
1003+
logger.error(`runWsPlugin: error in onClose handler for ${connection.id}: `, err);
1004+
}
10001005
}
10011006
manager.remove(connection.id);
10021007
}

0 commit comments

Comments
 (0)