fix: errors throwing logic

Author: Andrea Cosentino

src/utils/plugin.ts

@@ -196,8 +196,7 @@ async function handlingApiFsRequest(logger: ILogger, fullUrl: URL, request: Univ
 								Utils.request.applyPaginationAndFilters(request, paginationHandler, filtersHandler, paginationPlugin, filtersPlugin, dataFile);
 							} catch (error: any) {
 								if (error instanceof UniversalApiError) {
-									if (error.getType() === "MANUALLY_HANDLED") {
-										error.setType("ERROR");
+									if (!error.getPath()) {
 										error.setPath(fullUrl.pathname);
 									}
 									throw error;
@@ -271,8 +270,7 @@ async function handlingApiFsRequest(logger: ILogger, fullUrl: URL, request: Univ
 								Utils.request.applyPaginationAndFilters(request, paginationHandler, filtersHandler, paginationPlugin, filtersPlugin, dataFile);
 							} catch (error: any) {
 								if (error instanceof UniversalApiError) {
-									if (error.getType() === "MANUALLY_HANDLED") {
-										error.setType("ERROR");
+									if (!error.getPath()) {
 										error.setPath(fullUrl.pathname);
 									}
 									throw error;
@@ -376,8 +374,7 @@ async function handlingApiFsRequest(logger: ILogger, fullUrl: URL, request: Univ
 					await Utils.files.writingFile(file, fileFound, newData, dataFile.mimeType, true);
 				} catch (error: any) {
 					if (error instanceof UniversalApiError) {
-						if (error.getType() === "MANUALLY_HANDLED") {
-							error.setType("ERROR");
+						if (!error.getPath()) {
 							error.setPath(fullUrl.pathname);
 						}
 						throw error;
@@ -412,8 +409,7 @@ async function handlingApiFsRequest(logger: ILogger, fullUrl: URL, request: Univ
 							}
 						} catch (error: any) {
 							if (error instanceof UniversalApiError) {
-								if (error.getType() === "MANUALLY_HANDLED") {
-									error.setType("ERROR");
+								if (!error.getPath()) {
 									error.setPath(fullUrl.pathname);
 								}
 								throw error;

src/utils/utils.ts

@@ -15,7 +15,7 @@ function patchWalkPath(target: any, path: string) {
 	if (path === '' || path === '/') {
 		throw new UniversalApiError(
 			"PATCH body request malformed: cannot use root path for this operation",
-			"MANUALLY_HANDLED",
+			"ERROR",
 			"",
 			Constants.HTTP_STATUS_CODE.BAD_REQUEST
 		);
@@ -26,7 +26,7 @@ function patchWalkPath(target: any, path: string) {
 	for (let i = 0; i < segments.length - 1; i++) {
 		const key = segments[i];
 		if (!(key in current)) {
-			throw new UniversalApiError("PATCH body request malformed", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+			throw new UniversalApiError("PATCH body request malformed", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 		}
 		current = current[key];
 	}
@@ -270,13 +270,13 @@ export const Utils = {
 			} else {
 				// INFO RFC 6902 standard (JSON Patch)
 				if (!Array.isArray(patch)) {
-					throw new UniversalApiError("PATCH body request malformed", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+					throw new UniversalApiError("PATCH body request malformed", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 				}
 				result = Utils.plugin.cloneData(data);
 				patch.forEach(operation => {
 					const { op, path, value, from } = operation;
 					if (!op || !path) {
-						throw new UniversalApiError("PATCH body request malformed", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+						throw new UniversalApiError("PATCH body request malformed", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 					}
 					switch (op) {
 						case 'add': {
@@ -295,7 +295,7 @@ export const Utils = {
 								parent.splice(parseInt(key), 1);
 							} else {
 								if (!(key in parent)) {
-									throw new UniversalApiError("PATCH body request malformed", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+									throw new UniversalApiError("PATCH body request malformed", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 								};
 								delete parent[key];
 							}
@@ -304,7 +304,7 @@ export const Utils = {
 						case 'replace': {
 							const { parent, key } = patchWalkPath(result, path);
 							if (!(key in parent)) {
-								throw new UniversalApiError("PATCH body request malformed", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+								throw new UniversalApiError("PATCH body request malformed", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 							};
 							parent[key] = value;
 							break;
@@ -338,7 +338,7 @@ export const Utils = {
 							break;
 						}
 						default:
-							throw new UniversalApiError(`PATCH operation not supported: ${op}`, "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+							throw new UniversalApiError(`PATCH operation not supported: ${op}`, "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 					}
 				})
 			}
@@ -1038,7 +1038,7 @@ export const Utils = {
 				if (pagination !== null && Array.isArray(dataFile.data)) {
 					if (pagination.sort !== null && pagination.order !== null) {
 						if (!["ASC", "DESC", "1", "-1", "true", "false"].includes(pagination.order)) {
-							throw new UniversalApiError("Error parsing pagination request", "MANUALLY_HANDLED", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
+							throw new UniversalApiError("Error parsing pagination request", "ERROR", "", Constants.HTTP_STATUS_CODE.BAD_REQUEST);
 						}
 						dataFile.data = dataFile.data.sort((a: any, b: any) => {
 							return ["ASC", "1", "true"].includes(pagination.order!)