|
| 1 | +--- |
| 2 | +phase: quick-380 |
| 3 | +plan: 01 |
| 4 | +subsystem: agent-skills |
| 5 | +tags: [skills, references, workflows, cleanup] |
| 6 | +dependency_graph: |
| 7 | + requires: [] |
| 8 | + provides: [trimmed-skill-set, enriched-core-references, quality-checklist-wiring] |
| 9 | + affects: [verify-phase, cleanup-review, nf-planner, install] |
| 10 | +tech_stack: |
| 11 | + added: [] |
| 12 | + patterns: [core-reference-enrichment, verifier-quality-scan] |
| 13 | +key_files: |
| 14 | + created: |
| 15 | + - core/references/testing-patterns.md |
| 16 | + - core/references/security-checklist.md |
| 17 | + - core/references/performance-checklist.md |
| 18 | + - core/references/accessibility-checklist.md |
| 19 | + modified: |
| 20 | + - core/references/tdd.md |
| 21 | + - core/references/git-integration.md |
| 22 | + - core/references/verification-patterns.md |
| 23 | + - agents/nf-planner.md |
| 24 | + - core/workflows/verify-phase.md |
| 25 | + - core/workflows/cleanup-review.md |
| 26 | + - docs/agent-skills.md |
| 27 | + - CONTRIBUTING.md |
| 28 | + - README.md |
| 29 | + - docs/USER-GUIDE.md |
| 30 | + deleted: |
| 31 | + - agents/skills/{11 removed skill directories} |
| 32 | + - commands/nf/{11 removed command routing files} |
| 33 | + - references/{4 checklist files moved to core/references/} |
| 34 | +decisions: |
| 35 | + - "Merged unique guidance from 11 removed skills into existing core references and workflows rather than creating new files" |
| 36 | + - "Added quality checklist scan as informational warnings in verifier, not blocking gates" |
| 37 | + - "ADR suggestion added to planner as optional guidance, not mandatory task requirement" |
| 38 | +metrics: |
| 39 | + duration: "8 minutes" |
| 40 | + completed: "2026-04-07" |
| 41 | + tasks: 3 |
| 42 | + files_created: 4 |
| 43 | + files_modified: 10 |
| 44 | + files_deleted: 30 |
| 45 | +--- |
| 46 | + |
| 47 | +# Quick Task 380: Trim Packaged Skills to 6, Merge Into Lifecycle Summary |
| 48 | + |
| 49 | +Trimmed packaged skills from 17 to 6 by merging 11 removed skills' unique guidance into core reference files and verifier/cleanup workflows, with 4 reference checklists moved from references/ to core/references/ with enrichments. |
| 50 | + |
| 51 | +## Tasks Completed |
| 52 | + |
| 53 | +### Task 1: Merge removed skills guidance into core references and workflows |
| 54 | +**Commit:** 652d5719 |
| 55 | + |
| 56 | +Enriched 3 existing core references: |
| 57 | +- `tdd.md` with Prove-It Pattern (bug-first TDD) and anti-patterns |
| 58 | +- `git-integration.md` with pre-commit checklist |
| 59 | +- `verification-patterns.md` with slicing strategies (vertical, contract-first, risk-first) |
| 60 | + |
| 61 | +Added ADR task suggestion to `nf-planner.md` for architectural decision capture. |
| 62 | + |
| 63 | +Moved 4 checklists from `references/` to `core/references/` with enrichments: |
| 64 | +- `testing-patterns.md` with test quality principles (state-based vs interaction-based) |
| 65 | +- `security-checklist.md` with pipeline gate ordering (fail-fast, cheapest-first) |
| 66 | +- `performance-checklist.md` with optimization cycle and common bottleneck patterns |
| 67 | +- `accessibility-checklist.md` (comprehensive as-is) |
| 68 | + |
| 69 | +Wired quality checklists into verifier workflow (informational scan after must_haves verification). Added simplification scanning category to cleanup-review workflow. |
| 70 | + |
| 71 | +### Task 2: Delete removed skills, command files, old references dir, update docs |
| 72 | +**Commit:** 807f0c5b |
| 73 | + |
| 74 | +Deleted 11 skill directories, 11 command routing files, and the old `references/` directory. Updated 4 documentation files to reflect exactly 6 remaining skills: idea-refine, task-intake, code-review-and-quality, api-and-interface-design, deprecation-and-migration, shipping-and-launch. |
| 75 | + |
| 76 | +### Task 3: Install sync and final verification |
| 77 | +**No commit** (install.js already copies entire core/ directory) |
| 78 | + |
| 79 | +Verified: |
| 80 | +- `node bin/install.js --claude --global` installs all 18 reference files to `~/.claude/nf/references/` |
| 81 | +- Installed workflows contain quality checklist scan and simplification scanning |
| 82 | +- `npm run test:ci`: 1392 tests pass, 0 fail |
| 83 | +- `npm run lint:isolation`: all portable-path checks passed |
| 84 | +- `npm run check:assets`: all 3 assets up to date |
| 85 | + |
| 86 | +## Deviations from Plan |
| 87 | + |
| 88 | +None -- plan executed exactly as written. |
| 89 | + |
| 90 | +## Final State |
| 91 | + |
| 92 | +- **6 packaged skills**: idea-refine, task-intake, code-review-and-quality, api-and-interface-design, deprecation-and-migration, shipping-and-launch |
| 93 | +- **18 core reference files** (14 existing + 4 moved checklists) |
| 94 | +- **Enriched verifier** with quality checklist scan step |
| 95 | +- **Enriched cleanup-review** with simplification scanning category |
| 96 | +- **Enriched planner** with ADR task suggestion |
| 97 | +- All CI gates pass |
| 98 | + |
| 99 | +## Self-Check |
| 100 | + |
| 101 | +Verifying claims: |
| 102 | +- core/references/testing-patterns.md: EXISTS |
| 103 | +- core/references/security-checklist.md: EXISTS |
| 104 | +- core/references/performance-checklist.md: EXISTS |
| 105 | +- core/references/accessibility-checklist.md: EXISTS |
| 106 | +- Commit 652d5719: EXISTS |
| 107 | +- Commit 807f0c5b: EXISTS |
| 108 | +- agents/skills/ count: 6 (CORRECT) |
| 109 | +- ~/.claude/nf/references/ count: 18 (CORRECT) |
| 110 | + |
| 111 | +## Self-Check: PASSED |
0 commit comments