Skip to content

Commit 07a506c

Browse files
committed
actually await the progress callback
1 parent fd54fc4 commit 07a506c

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

isideload/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "isideload"
33
description = "Sideload iOS/iPadOS applications"
44
license = "MIT"
55
authors = ["Nicholas Sharp <nab@nabdev.me>"]
6-
version = "0.3.4"
6+
version = "0.3.5"
77
edition = "2024"
88
repository = "https://github.com/nab138/isideload"
99
documentation = "https://docs.rs/isideload"

isideload/src/sideload/sign.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,12 @@ use crate::{
1313
util::plist::PlistDataExtract,
1414
};
1515

16-
pub fn sign<F, Fut>(
16+
pub async fn sign<F, Fut>(
1717
app: &mut Application,
1818
cert_identity: &CertificateIdentity,
1919
provisioning_profile: &Profile,
2020
special: &Option<SpecialApp>,
2121
team: &DeveloperTeam,
22-
// make progress callback async
2322
progress_callback: Option<F>,
2423
) -> Result<(), Report>
2524
where
@@ -42,7 +41,7 @@ where
4241

4342
for (index, bundle) in sorted_bundles.iter().enumerate() {
4443
if let Some(callback) = &progress_callback {
45-
callback(0.5 + 0.5 * (index as f32 / sorted_bundles.len() as f32));
44+
callback(0.5 + 0.5 * (index as f32 / sorted_bundles.len() as f32)).await;
4645
}
4746
info!(
4847
"Signing {}",

0 commit comments

Comments
 (0)