Skip to content

Fix input/change event triggers - #148

Open
BrianLeishman wants to merge 2 commits into
nadchif:masterfrom
BrianLeishman:master
Open

Fix input/change event triggers#148
BrianLeishman wants to merge 2 commits into
nadchif:masterfrom
BrianLeishman:master

Conversation

@BrianLeishman

Copy link
Copy Markdown

Arrow key movements and scroll buttons weren't triggering/creating synthetic input and change events.

Arrow key movements and scroll buttons weren't triggering/creating synthetic input and change events.
@nadchif

nadchif commented Apr 11, 2022

Copy link
Copy Markdown
Owner

Thank @BrianLeishman for this Pull Request. 🌟

While this would fix the issue of the arrow buttons and arrow keys, it results in this behavior:

Current Pull Request
updown1 updown2

See also: Failed Tests

We need to figure a way around that. Please feel welcome to let know where I could help

cc: @longtongj28 and @Liaxum (Have been working on fixing this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants