refactor: migrate ConsolePresenter to nl2sql_cli and enhance reporting features

- Moved ConsolePresenter from core to nl2sql_cli, streamlining the CLI reporting structure.
- Introduced new methods for interactive status updates, task management, and enhanced error/warning messages.
- Updated various command files to utilize the new ConsolePresenter methods for improved user feedback during operations.
- Removed the old reporting module from the core package to reduce redundancy and improve maintainability.

Author: nadeem4

packages/cli/src/nl2sql_cli/commands/benchmark.py

@@ -4,7 +4,7 @@
 from nl2sql.datasources import DatasourceRegistry
 from nl2sql.indexing.vector_store import VectorStore
 from nl2sql.evaluation.evaluator import ModelEvaluator
-from nl2sql.reporting import ConsolePresenter
+from nl2sql_cli.reporting import ConsolePresenter
 from nl2sql.runners.benchmark_runner import BenchmarkRunner
 from nl2sql_cli.types import BenchmarkConfig
 from nl2sql_cli.common.decorators import handle_cli_errors

packages/cli/src/nl2sql_cli/commands/indexing.py

@@ -1,5 +1,6 @@
+import json
 import sys
-from typing import Dict, Any
+from typing import Any, Dict
 from nl2sql_cli.reporting import ConsolePresenter
 from nl2sql.indexing.vector_store import VectorStore
 from nl2sql.datasources import DatasourceRegistry
@@ -28,33 +29,89 @@ def run_indexing(
     orchestrator = IndexingOrchestrator(ctx)
     stats = []
     errors = []
+    empty_stats = []
 
     presenter.start_interactive_status("Clearing existing data...")
-    orchestrator.clear_store()
+    try:
+        orchestrator.clear_store()
+    except Exception as e:
+        presenter.stop_interactive_status()
+        presenter.print_error(f"Failed to clear existing data: {e}")
+        sys.exit(1)
     presenter.stop_interactive_status()
     presenter.print_success("Cleared existing data.")
 
-    presenter.start_interactive_status("Indexing...")
-
     for adapter in adapters:
         ds_id = adapter.datasource_id
 
         try:
-            with presenter.status_context(f"{ds_id}..."):
-                schema_stats = orchestrator.index_datasource(adapter)
+            task = presenter.start_task_line(f"Indexing {ds_id}...")
+            schema_stats = orchestrator.index_datasource(adapter)
+            if schema_stats:
                 stats.append(schema_stats)
+            else:
+                empty_stats.append(ds_id)
+            presenter.finish_task_line(task, f"{ds_id} indexed", success=True)
         except Exception as e:
+            if "task" in locals():
+                presenter.finish_task_line(task, f"{ds_id} failed", success=False)
             presenter.print_error(f"Failed to index {ds_id}: {e}")
             errors.append(
                 {"datasource_id": ds_id, "error": str(e)}
             )
-
-    presenter.stop_interactive_status()
 
     if errors:
-        presenter.print_table(errors, "Indexing Errors")
+        presenter.print_table(errors, "Indexing Errors", columns=["datasource_id", "error"])
 
     if stats:
-        presenter.print_table(stats, "Indexing Summary")
+        summary_rows = []
+        total_chunks = 0
+        totals_by_type: Dict[str, int] = {}
+
+        for s in stats:
+            ds_id = s.get("datasource_id", "unknown")
+            schema_version = s.get("schema_version", "-")
+            chunk_stats = {
+                k: v for k, v in s.items()
+                if k not in ("datasource_id", "schema_version")
+            }
+            ds_total = sum(v for v in chunk_stats.values() if isinstance(v, int))
+            total_chunks += ds_total
+            for key, val in chunk_stats.items():
+                if isinstance(val, int):
+                    totals_by_type[key] = totals_by_type.get(key, 0) + val
+
+            summary_rows.append(
+                {
+                    "datasource_id": ds_id,
+                    "schema_version": schema_version,
+                    "total_chunks": ds_total,
+                    "chunks": json.dumps(chunk_stats, separators=(",", ":")),
+                }
+            )
 
-    presenter.print_success("Indexing complete.")
+        presenter.print_table(
+            summary_rows,
+            "Indexing Summary",
+            columns=["datasource_id", "schema_version", "total_chunks", "chunks"],
+        )
+
+        if totals_by_type:
+            totals_str = ", ".join([f"{k}={v}" for k, v in sorted(totals_by_type.items())])
+            presenter.print_info(f"Total chunks indexed: {total_chunks} ({totals_str})")
+
+    total_adapters = len(adapters)
+    succeeded = len(stats)
+    failed = len(errors)
+    skipped = len(empty_stats)
+    presenter.print_info(
+        f"Datasources: total={total_adapters}, succeeded={succeeded}, failed={failed}, empty={skipped}"
+    )
+
+    if empty_stats:
+        presenter.print_warning(f"Datasources with empty stats: {', '.join(empty_stats)}")
+
+    if errors:
+        presenter.print_warning("Indexing completed with errors.")
+    else:
+        presenter.print_success("Indexing complete.")

packages/cli/src/nl2sql_cli/commands/run.py

@@ -5,7 +5,7 @@
 from nl2sql.datasources import DatasourceRegistry
 from nl2sql.llm import LLMRegistry
 from nl2sql.indexing.vector_store import VectorStore
-from nl2sql.reporting import ConsolePresenter
+from nl2sql_cli.reporting import ConsolePresenter
 from nl2sql.runners.pipeline_runner import PipelineRunner
 from nl2sql.common.settings import settings
 from nl2sql_cli.types import RunConfig
@@ -23,6 +23,8 @@ def run_pipeline(
 
     presenter = ConsolePresenter()
     presenter.print_info(f"Query: {config.query}")
+    if config.no_exec:
+        presenter.print_warning("Execution disabled (no_exec). Only SQL/plan output will be shown.")
 
     # Instantiate Runner
     runner = PipelineRunner(ctx)
@@ -111,13 +113,30 @@ def run_pipeline(
     if errors:
         presenter.print_pipeline_errors(errors)
 
+    warnings = final_state.get("warnings") or []
+    for warning in warnings:
+        if isinstance(warning, dict):
+            presenter.print_warning(json.dumps(warning, default=str))
+        else:
+            presenter.print_warning(str(warning))
+
+    answer_payload = None
+    answer_synth = final_state.get("answer_synthesizer_response")
+    if answer_synth:
+        if isinstance(answer_synth, dict):
+            answer_payload = answer_synth.get("final_answer")
+        else:
+            answer_payload = getattr(answer_synth, "final_answer", None)
+    if isinstance(answer_payload, dict) and answer_payload:
+        presenter.print_answer_synthesizer_output(answer_payload)
+
     final_answer = final_state.get("final_answer")
-    if type(final_answer) == str and final_answer:
+    if isinstance(final_answer, dict) and final_answer:
+        presenter.print_answer_synthesizer_output(final_answer)
+    elif type(final_answer) == str and final_answer:
         presenter.print_final_answer(final_answer)
     elif type(final_answer) == list and final_answer:
         presenter.print_execution_result(final_answer)
-    else:
-        return
 
     execution = final_state.get("execution")
     if execution:

packages/cli/src/nl2sql_cli/commands/visualize.py

@@ -1,6 +1,6 @@
 from typing import List, Dict, Any
 from langgraph.graph.state import CompiledStateGraph
-from nl2sql.reporting import ConsolePresenter
+from nl2sql_cli.reporting import ConsolePresenter
 
 from nl2sql_cli.common.decorators import handle_cli_errors